Bug 58659

Make sure your kernel has this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=0953e76e91f4b6206cef50bd680696dc6bf1ef99

My kernel build does have that patch.

Unfortunately, I am having trouble bisecting because something that appears unrelated makes my system fail to boot.  That boot failure already been fixed in more recent builds thought :/.

Looks like this is probably a duplicate of this issue:
http://lists.freedesktop.org/archives/dri-devel/2012-December/032547.html
See if reverting commit 2d6cc729 fixes the problem.

Reverting patch 2d6cc729 does indeed fix the problem.

IN 3.8-rc3 this crash no longer happens.  However, there is a new graphical corruption when launching Steam's Big Picture.  This corruption stays until logoff.

It does not affect openbox/lxde, only compiz/unity which is why I thought it might be related to this bug or it's fix. It does not happen in 3.7.

https://docs.google.com/file/d/0B9PdLrdrtm1wQVRma3JNdzFNa0k/edit
Video of steam creating the issue, and then the issue disappearing (this doesn't usually happen)

https://docs.google.com/file/d/0B9PdLrdrtm1wS2RyV2g1SmRSbnc/edit
What usually happens to the rest of the desktop.

Created attachment 73018 [details]
tail -f output of Xorg, from starting big picture

Syslog doesn't report anything when this happens,  Xorg.0.log shows the following attachment (using tail -f).

Created attachment 73088 [details] [review]
possible fix

Does the attached kernel patch help?

Does reverting the following commit fix the corruption issue?

commit d025e9e2b890db679f1246037bf65bd4be512627
Author: Jerome Glisse <jglisse@redhat.com>
Date:   Thu Nov 29 10:35:41 2012 -0500

    drm/radeon: do not move bo to different placement at each cs

    The bo creation placement is where the bo will be. Instead of trying
    to move bo at each command stream let this work to another worker
    thread that will use more advance heuristic.

    agd5f: remove leftover unused variable

    Signed-off-by: Jerome Glisse <jglisse@redhat.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Reverting commit d025e9e2b890db679f1246037bf65bd4be512627 does indeed fix the Big Picture issue.  Will test the patch now..

Same issue as:
https://bugzilla.kernel.org/show_bug.cgi?id=52491

Adding the patch from comment #8 does not help.

Created attachment 73168 [details] [review]
Exclude system placement

Does applying this patch without reverting anything fix the issue ?

I tested with just this second patch and it did not help.

Do you want me to test with both patches applied?

You sure you using the module with the patch ? You rebuilded your initrd and all ?

Other user that pointed to same commit have the issue fixed by this patch. A better version of this patch is also at :
http://people.freedesktop.org/~glisse/0001-drm-radeon-exclude-system-placement-when-validating-.patch

I'm building with https://wiki.ubuntu.com/KernelTeam/GitKernelBuild#Kernel_Build_and_Installation
I'm running step 9 after doing git apply patch and then git commit.

I'll try the latest patch.

You also need step 12 of and please add :

printk(KERN_INFO "TITITOTOTUTUPOPO\n");

to

radeon_device.c line 992 after DRM_INFO("initializing ke ....

And when testing to make sure you are using the patched module dmesg | grep TITITOTO

should tell you if it's the case.

I didn't need to do step 12 to get the TITITOTO message printed.  I did what I've been doing all along.  (I'm also trying to update the GitKernelBuild page as I go)  If the message was printed that means it was loaded correctly, right?

The better version of the patch (drm-radeon-exclude-system-placement-when-validating) was tested and it still didn't work.

Updated patch

http://people.freedesktop.org/~glisse/0001-drm-radeon-exclude-system-placement-when-validating-.patch


Still weird that you point to same commit and first patch did not solve it.

This last patch (0001-drm-radeon-exclude-system-placement-when-validating) creates a full Xorg freeze:
Form xorg.log:
[   207.780] (WW) RADEON(0): flip queue failed: Invalid argument
[   207.781] (WW) RADEON(0): Page flip failed: Invalid argument
Repeated many times

From kern.log:
[  207.595082] radeon 0000:01:00.0: efaa7000 pin failed
[  207.595096] [drm:radeon_crtc_page_flip] *ERROR* failed to pin new rbo buffer before flip
[  207.595434] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -22!
[  207.601745] [drm:radeon_cs_ioctl] *ERROR* Failed to parse relocation -22!
[  207.602094] radeon 0000:01:00.0: efaa7000 pin failed
Repeated many times


I'm going to git pull to latest and try building again... Does it depend on some other patch?

A patch referencing this bug report has been merged in Linux v3.8-rc5:

commit 20707874fd4fd37e09513f508e642fa8bd06365a
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Thu Jan 17 13:10:50 2013 -0500

    Revert "drm/radeon: do not move bo to different placement at each cs"

Revert merged