Bug 58791

Summary: [ILK] Some modes can't light up on DP display
Product: DRI Reporter: shui yangwei <yangweix.shui>
Component: DRM/IntelAssignee: shui yangwei <yangweix.shui>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: major    
Priority: medium CC: bingx.a.yan, przanoni
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Some modes can't light up dmesg
none
modes-cannot-lightup.dmesg
none
dmesg: some dp display mode can't light up none

Description shui yangwei 2012-12-27 03:50:24 UTC
Created attachment 72162 [details]
Some modes can't light up dmesg

Environment:
-------------------------
Kernel: (drm-intel-next-queued)c0c36b941b6f0be6ac74f340040cbb29d6a0b06c
Some additional commit info:
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Dec 19 16:08:43 2012 +0000

Description:
-------------------------
Testing these modes below, monitor can't light up.

CRTS(3):[0]  1920x1200 60 1920 1968 2000 2080 1200 1203 1209 1235 0x9 0x48 154000
CRTS(3):[0]  1680x945 60 1680 1784 1960 2240 945 946 949 978 0x6 0x0 131481
CRTS(3):[0]  1280x1024 75 1280 1296 1440 1688 1024 1025 1028 1066 0x5 0x40 135000
Comment 1 yanbing 2013-01-21 06:21:10 UTC
New more modes can not light up on this commit.

Environment:
-------------------------
Kernel: (drm-intel-next-queued)fa22c28522f53b63c1b287da1b69dc5700eaa09f
Some additional commit info:
Author: Ben Widawsky <ben@bwidawsk.net>
Date:   Fri Jan 18 19:18:19 2013 -0800

    drm/i915: re-add dropped dma_mask configuration

Description:
-------------------------
Testing these modes below, monitor can't light up.:

CRTS(3):[0]  1920x1080 50 1920 2448 2492 2640 1080 1084 1089 1125 0x5 0x40 148500
CRTS(3):[0]  1600x1200 60 1600 1664 1856 2160 1200 1201 1204 1250 0x5 0x40 162000
CRTS(3):[0]  1400x1050 60 1400 1488 1632 1864 1050 1053 1057 1089 0x6 0x40 121750
CRTS(3):[0]  1440x900 75 1440 1536 1688 1936 900 903 909 942 0x6 0x40 136750

Testing these modes below, monitor can light up be in a certain probability,and after light up it also be a bug in bug 54687:

CRTS(3):[0]  1920x1080i 50 1920 2448 2492 2640 1080 1084 1094 1125 0x15 0x40 74250
CRTS(3):[0]  1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74250

I also add the dmesg called modes-cannot-lightup.dmesg
Comment 2 yanbing 2013-01-21 06:21:40 UTC
Created attachment 73356 [details]
modes-cannot-lightup.dmesg
Comment 3 Paulo Zanoni 2013-02-15 16:58:09 UTC
Hi

Does the following patch fix the problem?

https://bugs.freedesktop.org/attachment.cgi?id=74877

Thanks,
Paulo
Comment 4 yanbing 2013-02-19 07:23:44 UTC
(In reply to comment #3)
> Hi
> 
> Does the following patch fix the problem?
> 
> https://bugs.freedesktop.org/attachment.cgi?id=74877
> 
> Thanks,
> Paulo

I retest with this patch and the issue is be fixed.
Comment 5 Daniel Vetter 2013-02-20 11:05:17 UTC
Patch landed in upstream drm-next tree (and is now also included in -nightly):

commit 196e077dc165a307efbd9e7569f81bbdbcf18f65
Author: Paulo Zanoni <paulo.r.zanoni@intel.com>
Date:   Fri Feb 15 13:36:27 2013 -0200

    drm: don't add inferred modes for monitors that don't support them
Comment 6 shui yangwei 2013-05-06 09:08:35 UTC
Created attachment 78912 [details]
dmesg: some dp display mode can't light up

Environment:
------------------------
Kernel: (drm-intel-next-queued)2b87f3b1bab1df814057ff551f4fc49c22a7fde9
Some additional commit info:
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu May 2 15:30:47 2013 -0700

    drm/i915: fix Haswell pfit power well check v2

Description:
------------------------
In this round testing, this bug is reproduced, when test display with DP mode, the resolution below can't light up.
[0]  1920x1080 60 1920 2008 2052 2200 1080 1084 1089 1125 0x5 0x48 148500
[1]  1920x1080 50 1920 2448 2492 2640 1080 1084 1089 1125 0x5 0x40 148500
[2]  1920x1080 60 1920 1968 2000 2080 1080 1083 1088 1110 0x9 0x40 138500
[3]  1920x1080i 50 1920 2448 2492 2640 1080 1084 1094 1125 0x15 0x40 74250
[4]  1920x1080i 60 1920 2008 2052 2200 1080 1084 1094 1125 0x15 0x40 74250
[5]  1600x1200 60 1600 1664 1856 2160 1200 1201 1204 1250 0x5 0x40 162000
[7]  1280x1024 75 1280 1296 1440 1688 1024 1025 1028 1066 0x5 0x40 135000
Comment 7 Daniel Vetter 2013-05-06 09:14:30 UTC
Hm, that patch is included in -fixes/dinq now, so the regression should be a new bug.

Can you please file a new bug for this (this one here is getting messy), with a reference to this one? Also please try to bisect where this bug has been introduced, thanks.
Comment 8 Elizabeth 2017-10-06 14:47:19 UTC
Closing old verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.