| Summary: | Compile error: Missing (element-type) annotation. | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Hashem Nasarat <hnasarat> |
| Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | hnasarat, scampa.giovanni, will, xclaesse |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Compile error output
Add some missing introspection annotations |
||
Created attachment 72248 [details] [review] Add some missing introspection annotations Fix. Already reviewed by Rob on IRC, but neither of us could commit it for various reasons. Merged to master for 0.21.0 and 0.20 for 0.20.2. Actually tp_capabilities_get_channel_classes() should be annotated with (skip) because there is nothing useful you can do with (element-type GHashTable). The introspectable API is tp_capabilities_dup_channel_classes_variant(). I once had a patch that used (skip) on get_channel_classes(), but it was breaking some vala user (folks maybe, or maybe gnome-contacts, I don't remember). Anyway, the right element-type does not seem GHashTable to me, but GValueArray, as the underlying boxed type is a dbus-glib struct. (Just my 2 c.) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 72238 [details] Compile error output telepathy-glib from jhbuild does not compile for me with Debian Wheezy. dbus.c:884: Warning: TelepathyGLib: tp_asv_get_bytes: return value: Missing (element-type) annotation capabilities.c:87: Warning: TelepathyGLib: tp_capabilities_get_channel_classes: return value: Missing (element-type) annotation client-channel-factory.c:142: Warning: TelepathyGLib: tp_client_channel_factory_dup_channel_features: return value: Missing (element-type) annotation <unknown>:: Fatal: TelepathyGLib: warnings configured as fatal <unknown>:: Fatal: TelepathyGLib: warnings configured as fatal Attached is the log.