Bug 58865

Summary: Hardcoded product name in UI string
Product: LibreOffice Reporter: Andrea Pescetti <andrea.for.lists>
Component: SpreadsheetAssignee: Caolán McNamara <caolanm>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: valtermura
Version: 4.0.0.0.alpha0+ Master   
Hardware: Other   
OS: All   
Whiteboard: target:4.1.0
i915 platform: i915 features:

Description Andrea Pescetti 2012-12-29 15:50:47 UTC 
String 1I_3 (description: STR_QUERY_FORMULA_RECALC_ONLOAD_ODS ) in the English version has a hard-coded Product Name:

This document was last saved by application other than LibreOffice.  Some formula cells may produce different results when recalculated.

Assuming that the relevant code compares with [ProductName] and not with a literal "LibreOffice", [ProductName] should be used here too. On the other hand, if the code compares with a literal "LibreOffice" it should probably be fixed (at least, the behaviour should remain the same if I set [ProductName] to something else).

[Found during Italian translations for version 4.0]
Comment 1 Andrea Pescetti 2012-12-29 16:36:06 UTC 
The same issue applies to string i,jF (description: FT_ODF_RECALC ) which is relevant to the same function:

ODF Spreadsheet (not saved by LibreOffice)
Comment 2 Caolán McNamara 2013-01-11 11:45:04 UTC 
confirmed
Comment 3 Not Assigned 2013-01-11 20:16:37 UTC 
Caolan McNamara committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e610e5f28e4b2b774a897ee7cf6d8098ade30a7f

Resolves: fdo#58865 hard-coded LibreOffice strings



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.