Summary: | refuses all actions if user is member of a large number of groups | ||
---|---|---|---|
Product: | PolicyKit | Reporter: | Michael Biebl <mbiebl> |
Component: | daemon | Assignee: | David Zeuthen (not reading bugmail) <zeuthen> |
Status: | RESOLVED MOVED | QA Contact: | David Zeuthen (not reading bugmail) <zeuthen> |
Severity: | normal | ||
Priority: | medium | CC: | sascha-web-bugs.freedesktop.org |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | [PATCH] Fix get_groups_for_user() for large number of users |
Description
Michael Biebl
2012-12-30 14:43:11 UTC
Created attachment 72304 [details] [review] [PATCH] Fix get_groups_for_user() for large number of users get_groups_for_user() used a hard-coded limit for the number of groups before, barring all access to users with a large number of groups. . Dynamically allocate the list instead, potentially resizing it based on what getgroupslist() tells us. (In reply to comment #1) > Created attachment 72304 [details] [review] [review] > [PATCH] Fix get_groups_for_user() for large number of users > > get_groups_for_user() used a hard-coded limit for the number of > groups before, barring all access to users with a large number of > groups. > . > Dynamically allocate the list instead, potentially resizing it based > on what getgroupslist() tells us. We can do this but - the patch no longer applies to master - the patch does not follow the existing coding standards/conventions - no space between function name and beginning paranthesis - should use GLib memory allocation routines (g_new0/g_malloc/etc) - "if (!ptr)" should be "if (ptr == NULL)" (In reply to comment #2) > We can do this but > > - the patch no longer applies to master > > - the patch does not follow the existing coding standards/conventions > - no space between function name and beginning paranthesis > - should use GLib memory allocation routines (g_new0/g_malloc/etc) > - "if (!ptr)" should be "if (ptr == NULL)" Sascha, since you are reading this bug report and you are the original author of the patch, do you want to rework it according to David's comments? -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/polkit/polkit/issues/43. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.