Bug 59091

Summary:	Build with automake-1.13 broken
Product:	PolicyKit	Reporter:	Marko Lindqvist <cazfi74>
Component:	libpolkit	Assignee:	David Zeuthen (not reading bugmail) <zeuthen>
Status:	RESOLVED FIXED	QA Contact:	David Zeuthen (not reading bugmail) <zeuthen>
Severity:	normal
Priority:	medium	CC:	natanael.copa, nuno.araujo
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Fix Fix build with automake 1.13 Fix build with automake 1.13

Description Marko Lindqvist 2013-01-07 01:21:06 UTC

Created attachment 72604 [details]
Fix

Automake-1.13 removed long obsolete AM_CONFIG_HEADER and AM_PROG_CC_STDC completely (  http://lists.gnu.org/archive/html/automake/2012-12/msg00038.html ) and errors out upon seeing them.

Attached patch replaces AM_CONFIG_HEADER with proper AC_CONFIG_HEADERS. AM_PROG_CC_STDC is simply removed, as previous line already has AC_PROG_CC that does just the thing AM_PROG_CC_STDC.

Comment 1 David Zeuthen (not reading bugmail) 2013-01-09 20:00:29 UTC

This patch doesn't work for me (I'm on latest Fedora 18). It says

 config.status: error: cannot find input file: `Makefile.in'

and earlier

 configure.ac:6: error: required file 'config.h.in' not found

FWIW, I also think it's

 AC_CONFIG_HEADERS([config.h])

and not

 AC_CONFIG_HEADERS(config.h)

Comment 2 David Zeuthen (not reading bugmail) 2013-01-09 20:02:04 UTC

FWIW, I've removed AM_PROG_CC_STDC now.

Comment 3 Marko Lindqvist 2013-01-09 21:00:54 UTC

Is that error really new with this patch? Patch is really straightforward in replacing old AM_CONFIG_HEADER with the more modern AC_CONFIG_HEADERS that (in case of one config file) does the same. Have you run autoheader?
As for quotation, I simply didn't touch it. If you had AM_CONFIG_HEADER(config.h), I replaced it with AC_CONFIG_HEADERS(config.h) and not AC_CONFIG_HEADERS([config.h])

------

I'm mass submitting automake-1.13 fixes. Please see what you can do so
I don't need to do the same when automake-1.14 comes out:
http://cazfi.livejournal.com/195108.html

Comment 4 Nuno Araujo (IRC: russo79) 2013-01-15 17:24:12 UTC

Created attachment 73110 [details] [review]
Fix build with automake 1.13

This patch fixes the build with automake-1.13

The error about the missing Makefile.in was caused by autogen.sh
This patch also fix this problem.

Applies to HEAD.

Comment 5 Nuno Araujo (IRC: russo79) 2013-01-15 17:41:25 UTC

Created attachment 73111 [details] [review]
Fix build with automake 1.13

This patch fixes the build with automake 1.13 by using replacing the obsolete macros with the new ones.

This patch also fix the missing Makefile.in error.
It was caused because autoheader was not run anymore by autogen.sh

Applies to HEAD.

Comment 6 Kerrick Staley 2013-03-29 08:21:26 UTC

Could you please apply the patch that Nuno attached? This bug is over 2 months old.

Comment 7 David Zeuthen (not reading bugmail) 2013-04-02 17:19:10 UTC

Sorry for being slow. The patch looks good (I'm not very good with build systems though so ICBW) to me - I'll apply it tonight when I get home.

Comment 8 David Zeuthen (not reading bugmail) 2013-04-10 14:31:14 UTC

OK, finally pushed (been moving houses, that's why I'm slow). Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.