| Summary: | many new symbols in libxatracker after recent automake work | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Fabio Pedretti <pedretti.fabio> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | ||
| Version: | git | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 59304 | ||
| Attachments: |
xatracker visibility
visibility patch for xatracker1 |
||
|
Description
Fabio Pedretti
2013-01-11 11:58:35 UTC
If someone wants to write a patch for fixing the new symbols here is a reference how to fix this: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c8d3fd4a120be0f62367f679e31ea5763c10c197 I'd like to point out that there already were (and are) problems with symbol visibility: https://bugs.freedesktop.org/show_bug.cgi?id=37637 It would be nice if these could be fixed as well. Created attachment 73001 [details] [review] xatracker visibility I tried the attached patch, there are some less symbols but most are still here: https://launchpadlibrarian.net/128434393/buildlog_ubuntu-quantal-i386.mesa_9.1~git1301141056.e3e1ff~gd~q_BUILDING.txt.gz Note: it looks only libxatracker has this issue. Concerning visibility for the DRI drivers: Does anyone know which symbols have to be exported so that libGL can load the drivers? I've reduced the exported symbols via ld's --version-script to the ones containing dri, drm and glapi (mainly for bug #37637) -- which tremendously shrinks the amount. I would be interesting to know which symbols are exactly necessary for the loader to work. This problem looks related to libxatracker only. http://paste.ubuntu.com/1620151/plain/ is the patch I used to reduce visibility in debian-experimental, I could commit this if there is interest (In reply to comment #6) > http://paste.ubuntu.com/1620151/plain/ is the patch I used to reduce > visibility in debian-experimental, I could commit this if there is interest Maybe pastebin the patch in a place that I don't have to log in to see it? Actually, this is bugzilla -- just attach it here. Created attachment 74370 [details]
visibility patch for xatracker1
Just a minor thing: looking at the content of GALLIUM_CFLAGS shouldn't they be added to AM_CPPFLAGS instead of AM_CFLAGS ? Also, given that $(DEFINES) variable is technically deprecated, that should probably be adjusted too. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.