Bug 5938

Summary:	0.10.7 compile error
Product:	FriBidi	Reporter:	Jens Granseuer <jensgr>
Component:	general	Assignee:	Behdad Esfahbod <freedesktop>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high
Version:	unspecified
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	change include order

Description Jens Granseuer 2006-02-18 20:48:05 UTC

Compilation fails because the compiler doesn't know the iconv_t type
in fribidi_main.c. This because

#ifdef FRIBIDI_NO_CHARSETS
#include <iconv.h>
#endif

comes before

#include "fribidi.h"

where FRIBIDI_NO_CHARSETS is defined (if it isn't defined in config.h already).
On my system the result is that iconv.h is not included, but FRIBIDI_NO_CHARSETS
is defined later anyway.

So, the fix is to simply change the include order. Patch follows.

Comment 1 Jens Granseuer 2006-02-18 20:48:26 UTC

Created attachment 4659 [details] [review]
change include order

Comment 2 Behdad Esfahbod 2006-02-23 17:29:02 UTC

Thanks.

2006-02-23  Behdad Esfahbod <behdad@gnu.org>
        * fribidi_main.c: #include fribidi.h before checking for iconv.
        (fixes fd.o bug #4659)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.