| Summary: | [i965 Bisected]Oglc fbblit(advanced.blitFb-3d-cube.mirror.both) fails | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Anuj Phogat <anuj.phogat> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | idr, xunx.fang |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | output | ||
|
Description
lu hua
2013-01-17 03:09:54 UTC
Following cases fail on ironlake and pineview with mesa master branch, have same bisect info: Piglit cases: spec_ARB_ES2_compatibility_FBO_blit_from_missing_attachment_(ES2_completeness_rules) spec_ARB_ES2_compatibility_FBO_blit_to_missing_attachment_(ES2_completeness_rules) spec_ARB_framebuffer_object_FBO_blit_from_missing_attachment spec_ARB_framebuffer_object_FBO_blit_to_missing_attachment spec_ARB_framebuffer_object_framebuffer-blit-levels_draw_depth spec_ARB_framebuffer_object_framebuffer-blit-levels_read_depth spec_EXT_packed_depth_stencil_fbo-blit-d24s8 Oglc cases: fbblit(advanced.blitFb-3d-cube.fragop.scissortest) fbblit(advanced.blitFb.bounds) fbblit(advanced.blitFb.fragop.alphatest) fbblit(advanced.blitFb.fragop.depthtest) fbblit(advanced.blitFb.fragop.scissortest) fbblit(advanced.blitFb.fragop.stenciltest) fbo-multisample(advanced.blit.defaulttomsaa.colordepth) fbo-multisample(advanced.blit.singletomsaa.colordepth) fboarb(basic.blit.colorandepth) It also fails on mesa 9.1 branch. Posted a patch on mesa-dev which fixes this failure: http://permalink.gmane.org/gmane.comp.video.mesa3d.devel/53209 Reported tests pass on Sandybridge Mobile after following commit: Author: Anuj Phogat <anuj.phogat@gmail.com> Date: Fri Feb 15 11:03:08 2013 -0800 meta: Allocate texture before initializing texture coordinates tex->Sright and tex->Ttop are initialized during texture allocation. This fixes depth buffer blitting failures in khronos conformance tests when run on desktop GL 3.0. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=59495 Note: This is a candidate for stable branches. Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Chad Versace <chad.versace@linux.intel.com> Marking the bug resolved/fixed. It still fails on mesa 9.1 branch.
fbblit(negative.nullblit.zeroSize) still core dumped on mesa master and 9.1 branch.
output:
Intel OpenGL Conformance Test
Version ENG (Mar 5 2013 17:33:58)
CLI options echo:
oglconform -suite all -v 2 -test fbblit negative.nullblit.zeroSize
Window will be recreated 12 times.
Window 0 will run 1 testcases on config with id 128.
Window 1 will run 1 testcases on config with id 124.
Window 2 will run 1 testcases on config with id 106.
Window 3 will run 1 testcases on config with id 102.
Window 4 will run 1 testcases on config with id 129.
Window 5 will run 1 testcases on config with id 107.
Window 6 will run 1 testcases on config with id 122.
Window 7 will run 1 testcases on config with id 100.
Window 8 will run 1 testcases on config with id 125.
Window 9 will run 1 testcases on config with id 103.
Window 10 will run 1 testcases on config with id 123.
Window 11 will run 1 testcases on config with id 101.
Total of 12 testcases will be executed.
Setup Report.
Verbose level = 2.
Path inactive.
Visual Report for ID 128 (32 bits).
ID |ACCELERA|DB |REND_T |SURF_T |C_BUF_T |BUF_S |RED_S |
128| 1| 1| gl| wipbpx| rgba| 32| 8|
GREEN_S |BLUE_S |ALPHA_S |DEPTH_S |STENC_S |ACCUM_S |SPL_BUF |SAMPLES |
8| 8| 8| 24| 8| 0| 0| 0|
SRGB |TEX_RGB |TEX_RGBA|CAVEAT |SWAP |M_PBUF_W|M_PBUF_H|M_PBUF_P
0| 0| 0| none| undef| 0| 0| 0
OpenGL Report.
Vendor - 'Intel Open Source Technology Center'
Renderer - 'Mesa DRI Intel(R) Ivybridge Mobile '
Version - '3.0 Mesa 9.2-devel (git-e291247)' (3.0)
GLSL Version - '1.30'
Context Flags - None
>> Framebuffer blit (fbblit) test:
--> 4.4 - negative.nullblit.zeroSize subcase:
Floating point exception (core dumped)
(gdb) bt
#0 0x00007ffff62a8c3c in _mesa_meta_BlitFramebuffer (ctx=0x34c2880, srcX0=0, srcY0=0, srcX1=0, srcY1=0, dstX0=1, dstY0=1, dstX1=99, dstY1=99, mask=<optimized out>,
filter=9729) at ../../../src/mesa/drivers/common/meta.c:1794
#1 0x00007ffff617a30a in _mesa_BlitFramebuffer (srcX0=0, srcY0=0, srcX1=0, srcY1=0, dstX0=<optimized out>, dstY0=1, dstX1=99, dstY1=99, mask=16384, filter=9729)
at ../../../src/mesa/main/fbobject.c:3198
#2 0x0000000001331439 in (anonymous namespace)::fbblit::testcases::negativeZeroSizeBlit() ()
#3 0x0000000001331629 in long (anonymous namespace)::fbblit::runSubcaseAndHandleUnsupportedFbo<&(anonymous namespace)::fbblit::testcases::negativeZeroSizeBlit>() ()
#4 0x00000000013331d1 in FramebufferBlitExec(testParameters*) ()
#5 0x0000000001843a19 in callFunctionHandleExceptionsInner(long (*)(testParameters*), testParameters*, char*) ()
#6 0x0000000001843b6f in callFunctionHandleExceptions(long (*)(testParameters*), testParameters*) ()
#7 0x0000000001842801 in DriverExec(long (*)(testParameters*), testParameters*) ()
#8 0x0000000001779345 in Driver(std::vector<std::pair<std::string, std::string>, std::allocator<std::pair<std::string, std::string> > > const&, std::vector<driverRec*, std::allocator<driverRec*> > const&, std::vector<boost::shared_ptr<PrePostTestAction>, std::allocator<boost::shared_ptr<PrePostTestAction> > > const&, std::vector<boost::shared_ptr<PrePostTestcaseAction>, std::allocator<boost::shared_ptr<PrePostTestcaseAction> > > const&) ()
#9 0x0000000001779df8 in (anonymous namespace)::MyMessagePump::idle() ()
#10 0x000000000174b0f0 in MessagePump::process_messages() ()
#11 0x0000000001778404 in ExecutionManager::execute_schedules() ()
#12 0x0000000001717a1f in tkShellExecute(std::vector<std::pair<std::string, std::string>, std::allocator<std::pair<std::string, std::string> > > const&, std::vector<std::pair<std::string, std::string>, std::allocator<std::pair<std::string, std::string> > > const&) ()
#13 0x00000000004287c5 in main ()
fbblit(negative.nullblit.zeroSize) doesn't look like a regression caused by commit 0c535ae. I couldn't make the test pass with revisions prior to 0c535ae on mesa master. I think bisected commit is incorrect for this test case. I've anyway posted a patch on mailing list to fix this issue. fixed on mesa master: commit d78dcdf103271c539ff246651236e71f7a9c10fd Author: Anuj Phogat <anuj.phogat@gmail.com> Date: Thu Mar 7 14:05:38 2013 -0800 mesa: Fix FB blitting in case of zero size src or dst rect Framebuffer blitting operation should be skipped if any of the dimensions (width/height) of src/dst rect is zero. V2: Move the dimension check after error checking in _mesa_BlitFramebuffer. Fixes: fbblit(negative.nullblit.zeroSize) in Intel oglconform https://bugs.freedesktop.org/show_bug.cgi?id=59495 Note: Candidate for all the stable branches. Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Paul Berry <stereotype441@gmail.com> It fixed on mesa master branch. When fbblit(negative.nullblit.zeroSize) fixed on 9.1 branch, I will closed it. Verified.Fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.