Bug 59510

Summary: [PNV Bisected]Piglit spec_EGL_KHR_create_context_default_minor_version_GL fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i915Assignee: Chad Versace <chadversary>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: idr, xunx.fang
Version: unspecified   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description lu hua 2013-01-17 08:44:29 UTC 
System Environment:
--------------------------
Arch:             i386
Platform:         Pineview
Libdrm:		(master)libdrm-2.4.40-13-g9e6f96a579fc2ed241e9a31a35a5995129ee8f7a
Mesa:       (master)56c01d81094795286828ecb83713e043695e905a 
Xserver:(master)xorg-server-1.13.99.901-2-g6703a7c7cf1a349c137e247a0c8eb462ff7b07be
Xf86_video_intel: (master)2.20.17-88-g2113f7f440dd2f10e80f0bb3bd5cd155f7e19098
Cairo:	(master)1dfea39841fc6d545e45420b1999239f29556c05
Libva:	(staging)21649988d6b532cc96f633db017d1e4369f640e9
Libva_intel_driver:(staging)788e99361208127763fdf1e146e63fca03a09f67
Kernel:	(drm-intel-nightly) 644e43935a4b9a61460fa4bf449b79032556fb90

Bug detailed description:
-------------------------
It fails on pineview with mesa master branch. Works well on 9.0 branch.

Bisect shows:a11fe62058ad9d44170be9346111e3f6630a3327 is the first bad commit
commit a11fe62058ad9d44170be9346111e3f6630a3327
Author:     Chad Versace <chad.versace@linux.intel.com>
AuthorDate: Wed Nov 21 16:22:19 2012 -0800
Commit:     Ian Romanick <ian.d.romanick@intel.com>
CommitDate: Tue Jan 15 13:45:51 2013 -0800

    intel: Move validation of context version into intelInitContext

    Each driver (i830, i915, i965) used independent but similar code to
    validate the requested context version. With the rececnt arrival of GLES3,
    that logic has needed an update. Rather than apply identical updates to
    each drivers validation code, let's just move the validation into the
    shared routine intelInitContext.

    This refactor required some incidental changes to functions
    i830CreateContext and intelInitContext. For each function, this patch:
        - Adds context version parameters to the signature.
        - Adds a DRI_CTX_ERROR out param to the signature.
        - Sets the DRI_CTX_ERROR at each early return.


output:
eglCreateContext() failed
PIGLIT: {'result': 'fail' }


Reproduce steps:
----------------
1. xinit
2. ./bin/egl-create-context-default-minor-version-gl -auto
Comment 1 Chad Versace 2013-01-29 18:50:16 UTC 
Change status to RESOLVED/FIXED.

The Mesa patch fixed incorrect behavior, which revealed a bug in the test. Bug is fixed in Piglit by

commit 637a8e27850ee6c6bd00fed805687149230911d1
Author: Chad Versace <chad.versace@linux.intel.com>
Date:   Mon Jan 28 16:40:09 2013 -0800

    egl_khr_create_context: Fix for drivers that don't support GL >= 2.0
    
    Fix for test egl_khr_create_context/default-minor-version-gl.
    
    According to comments in the test: "The Linux OpenGL ABI only requires
    OpenGL 1.2, so this might fail to create a context." If the driver failed
    to create a 2.x context, then the test failed. This patch changes it to
    skip.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59510
    Reported-by: Lu Hua <huax.lu@intel.com>
    Acked-by: Matt Turner <mattst88@gmail.com>
    Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
Comment 2 lu hua 2013-02-26 05:50:25 UTC 
Verified.Fixed on latest mesa master branch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.