| Summary: | Writer's doc import and export fails to support comments attached to ranges | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | OfficeUser <norbert.notz> |
| Component: | Writer | Assignee: | Miklos Vajna <vmiklos> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | coffeetastesawesome, ikuya, jmadero.dev, kpijarski, moritz-freedesktop, vmiklos |
| Version: | 4.0.0.1 rc | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=38244 | ||
| Whiteboard: | target:4.1.0 | ||
| i915 platform: | i915 features: | ||
|
Description
OfficeUser
2013-01-17 20:56:36 UTC
I can confirm this behaviour in 4.0rc1. Comments for text ranges are not exported to .doc. However, they are working fine in the export to .docx. Please update the .doc export to include comments for text ranges. As Gerry has confirmed this, marking as NEW. NEW (Confirmed) Minor (wouldn't really prevent high quality work from what I can see, just an annoyance) High (as it's a new feature in 4.0, it should really work correctly) *** Bug 52958 has been marked as a duplicate of this bug. *** (In reply to comment #3) > *** Bug 52958 has been marked as a duplicate of this bug. *** Interesting to see that the new bug that was opened makes the old bug report a duplicate... :-) Normally it is the other way around. It's indeed not logical, but hey, it's already done, doesn't make too much sense to reverse it now. Anyway, I'll look into this. We tend not to do that in QA but sometimes we'll do a BT or a bibisect and just mark the older one as a dupe. We'll try to be a bit better about this as QA but in general I think we're pretty good :) Miklos Vajna committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7907cc0ef9751d553014bd3bab49be9e7fc31bca fdo#59530 WW8 import of commented text ranges The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Can the status of this bug be changed to RESOLVED -> FIXED? According to comment 7, there was already a patch. Did it solve the issue? The import patch only supports comments which start and end at the same paragraph, so it's not complete. The export part is missing. So please don't close it yet. *** Bug 63496 has been marked as a duplicate of this bug. *** Remaining parts are solved by these commits: Export: 5969eec0e998804eba77338b17de90737e2acb43 Import of comments affects more paragraphs: f2945255df273404ee2457dcf761cb8f334b732b More useful links: Export: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5969eec0e998804eba77338b17de90737e2acb43 Import of comments affects more paragraphs: http://cgit.freedesktop.org/libreoffice/core/commit/?id=f2945255df273404ee2457dcf761cb8f334b732b |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.