Bug 59691

Summary: [master] There is garbage when decoding some VC1 stream.
Product: libva Reporter: Du Yan <yanx.du>
Component: intelAssignee: xiaowei <xiaowei.a.li>
Status: VERIFIED NOTOURBUG QA Contact: Sean V Kelley <seanvk>
Severity: normal    
Priority: medium CC: haihao.xiang, ouping.zhang, yanx.du
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: A scratch patch for mplayer-vaapi (FFmpeg) for VC-1 multi slice decoding

Description Du Yan 2013-01-22 02:13:11 UTC 
Environment
---------------------------
Platform: IVB
libva: master 9f4dedc4de014cc665c32dfbac1c017f9396b563
interl driver: master 88b21b9aba9be13e08109fe5d213973447f38558


Bug Info
-----------------------
There is garbage when decoding some VC1 files with master branch.
(It is OK with qa branch.)

SA00049.vc1
SA00059.vc1
SA10097.vc1
SA10131.vc1
SA20021.vc1
SA30030.vc1
SA40013.vc1


Steps
---------------------
1. xinit&
2. $ mplayer -nosound -fps 10 -vo vaapi -va vaapi /home/VC1_conformance/bitstreams/SA10131.vc1
Comment 1 haihao 2013-01-23 05:09:19 UTC 
I cherry-picked a commit from commit a76acf6441a414bb5dd601485ed8ed790218bb13 in staging, could you re-test these clips ?

commit 7803fcae62c868c26f24425df04aee0405342563
Author: Li, Xiaowei A <xiaowei.a.li@intel.com>
Date:   Wed Dec 12 09:16:25 2012 +0800

    Fill the bitplane for VC1 skip picture decoding
Comment 2 Du Yan 2013-01-23 08:22:06 UTC 
Issue can't be reproduced in stagin branch. only exist in master branch.
Comment 3 Gwenole Beauchesne 2013-01-23 17:34:23 UTC 
(In reply to comment #0)
> There is garbage when decoding some VC1 files with master branch.
> (It is OK with qa branch.)
> 
> SA00049.vc1
> SA00059.vc1
> SA10097.vc1
> SA10131.vc1
> SA20021.vc1
> SA30030.vc1
> SA40013.vc1

All those streams have several slices per frame. Does your mplayer version support those? Otherwise, they now all work with gstreamer-vaapi git master branch (commit efd9011).
Comment 4 haihao 2013-01-24 02:01:04 UTC 
(In reply to comment #3)
> (In reply to comment #0)
> > There is garbage when decoding some VC1 files with master branch.
> > (It is OK with qa branch.)
> > 
> > SA00049.vc1
> > SA00059.vc1
> > SA10097.vc1
> > SA10131.vc1
> > SA20021.vc1
> > SA30030.vc1
> > SA40013.vc1
> 
> All those streams have several slices per frame. Does your mplayer version
> support those? 

Yes. I have a scratch patch for  it.
Comment 5 haihao 2013-01-24 02:03:44 UTC 
Created attachment 73547 [details] [review]
A scratch patch for mplayer-vaapi (FFmpeg) for VC-1 multi slice decoding
Comment 6 Du Yan 2013-01-24 06:01:46 UTC 
(In reply to comment #5)
> Created attachment 73547 [details] [review] [review]
A scratch patch for
> mplayer-vaapi (FFmpeg) for VC-1 multi slice decoding

Test OK after patch mplayer. garbage disappeared.
Comment 7 haihao 2013-01-24 06:18:43 UTC 
(In reply to comment #2)
> Issue can't be reproduced in stagin branch. only exist in master branch.

> Test OK after patch mplayer. garbage disappeared.

Do you not use the same version of mplayer for testing ?
Comment 8 Du Yan 2013-01-24 06:22:49 UTC 
(In reply to comment #7)
> (In reply to comment #2)
> Issue can't be reproduced in stagin branch. only
> exist in master branch.

> Test OK after patch mplayer. garbage disappeared.
> Do you not use the same version of mplayer for testing ?

I use the same version mplayer for testing.

mplayer: hwaccel-vaapi f1ad459a263f8537f6cba3bf479daea61c6104b9
Comment 9 haihao 2013-01-24 06:45:57 UTC 
I am confused.  You said  you can't reproduced this issue with staging  branch, so your player should support multi slice decoding.  Why do you need this patch https://bugs.freedesktop.org/attachment.cgi?id=73547 for your player  ?
Comment 10 Du Yan 2013-01-24 08:26:58 UTC 
Test on staging branch, I reset and rebuild the mplayer, issue can be reproduced.
So it is mplayer bug, not our driver.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.