| Summary: | fontconfig is not compatible with automake 1.13 | ||
|---|---|---|---|
| Product: | fontconfig | Reporter: | Quentin "Sardem FF7" Glidic <sardemff7+freedesktop> |
| Component: | conf | Assignee: | fontconfig-bugs |
| Status: | RESOLVED FIXED | QA Contact: | Behdad Esfahbod <freedesktop> |
| Severity: | normal | ||
| Priority: | medium | CC: | akira, freedesktop |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Fix tests with automake 1.13
Fix tests with automake 1.13 Fix tests (including doc) with automake 1.13 Fix tests (including doc) with automake 1.13 Fix tests (including doc) with automake 1.13 |
||
Thanks for the patch. committed into master. But when were these things added to automake? Ok, I see these are supposed to already be supported in 1.11.3 at least.
I like to take this opportunity to say that 1.13 simply broke backward compatibility. This is from the manual of 1.11.3:
" The variable `TESTS_ENVIRONMENT' can be used to set environment
variables for the test run; the environment variable `srcdir' is set in
the rule. If all your test programs are scripts, you can also set
`TESTS_ENVIRONMENT' to an invocation of the shell (e.g. `$(SHELL) -x'
can be useful for debugging the tests), or any other interpreter. For
instance, the following setup may be used to run tests with Perl:
TESTS_ENVIRONMENT = $(PERL) -Mstrict -w
TESTS = foo.pl bar.pl baz.pl
"
Do we know which version were the new facilities introduced in? In many of my modules I don't want to upgrade from 1.11.1 requirement.
This incompatible stuff seems appears after 1.13. as you pointed out, it doesn't work with even 1.12.2. let's revert this change and hopefully this will be settled down in automake upstream. Ok, then we need to communicate this upstream. Created attachment 74223 [details] [review] Fix tests with automake 1.13 This change *is* compatible with automake 1.11.1 TESTS_ENVIRONMENT is deprecated in the current usage since automake 1.12 I forgot to use parallel-tests, which is needed for LOG_COMPILER to be used. Here is a new patch (which replaces the old one) to make it work with automake 1.11 and 1.12 Please update doc/Makefile.am too. Created attachment 74236 [details] [review] Fix tests (including doc) with automake 1.13 Created attachment 74237 [details] [review] Fix tests (including doc) with automake 1.13 Fix typo in the commit message New patch doesn't include the original changes. Created attachment 74254 [details] [review] Fix tests (including doc) with automake 1.13 Sorry, complete patch attached. That looks good to me and works fine with automake 1.12.2. committed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 74094 [details] Fix tests with automake 1.13 Fontconfig tests use TESTS_ENVIRONMENT the wrong way. Since automake 1.13 it makes tests fail with the introduction of the test-driver script. Attached a patch to fix the issue.