Bug 60405

Summary: Review the usage of pa_memblockq_push()
Product: PulseAudio Reporter: Tanu Kaskinen <tanuk>
Component: miscAssignee: pulseaudio-bugs
Status: RESOLVED MOVED QA Contact: pulseaudio-bugs
Severity: normal    
Priority: medium CC: lennart
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Tanu Kaskinen 2013-02-07 09:23:05 UTC 
In many places the return value of pa_memblockq_push() and pa_memblockq_push_align() isn't checked (a negative return value indicates that the queue is full). In some places the function can't fail (an assertion could be added for these), and in some places we're missing proper error handling in case the queue gets full.

There is already a patch[1] that adds some assertions. I don't apply it now, because it's old and might need updating for the current codebase, and it's incomplete anyway (many FIXME items).

Another issue is that pa_memblock_push_align() is often used where pa_memblockq_push() could be used.

[1] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/13312
Comment 1 GitLab Migration User 2018-07-30 09:37:44 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/59.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.