| Summary: | Freeze and unfreeze don't modify document | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Urmas <davian818> |
| Component: | Spreadsheet | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | Joel Madero <jmadero.dev> |
| Severity: | minor | ||
| Priority: | low | CC: | bfo.bugmail, billhook, bjlockie, brownboyjohn, brucehohl, bug51066.10.pr0rsus, djones.jfv, dlambert716, futuria, guilleron29, ign_christian, jmadero.dev, jorendc, kevinmarkwell, lgodard.libre, mihovil, miscellaneous, ppguara, santos_e_silva, satenderkumar, ScottDrasnin, se_massey, stgohi-lobugs, vladisslav, wfheua |
| Version: | 3.6.4.3 release | ||
| Hardware: | Other | ||
| OS: | All | ||
| See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=38646 https://bugs.freedesktop.org/show_bug.cgi?id=57324 https://bugs.freedesktop.org/show_bug.cgi?id=63344 https://bugs.freedesktop.org/show_bug.cgi?id=59375 |
||
| Whiteboard: | EasyHack,DifficultyBeginner,SkillCpp,TopicCleanup target:4.1.0 target:4.0.4 | ||
| i915 platform: | i915 features: | ||
|
Description
Urmas
2013-02-18 12:23:01 UTC
Same with 3.6.4.3 - changing version to reflect this. Bodhi Linux Would be nice to be able to save the window freeze settings. If you do file -> save as it works so it definitely is just the modified boolean that isn't being ticked. ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Marking as: New (confirmed) Minor (we tend to use trivial only for things like labels and really simple thing that don't impact work at all, this could potentially impact work so marking as MINOR) Low (quite easy to fix I think and quite useful but a minor bug none the less) ProposedEasyHack *** Bug 56000 has been marked as a duplicate of this bug. *** The code change should be ~trivial. Poke at: void ScTabView::FreezeSplitters( bool bFreeze ) in sc/source/ui/view/tabview.cxx And IFF the splitter status changes, then we need to mark the document modified: Then I guess we need to somehow call: pDocSh->SetDocumentModified() And we should be done. Sameer Deshmukh committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7653d041792a878dc2f304e77f36da78588adaa5 fdo#61060 - Freezing now marks spreadsheet as unsaved. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. *** Bug 33688 has been marked as a duplicate of this bug. *** *** Bug 62000 has been marked as a duplicate of this bug. *** *** Bug 50129 has been marked as a duplicate of this bug. *** *** Bug 63224 has been marked as a duplicate of this bug. *** *** Bug 63103 has been marked as a duplicate of this bug. *** *** Bug 62045 has been marked as a duplicate of this bug. *** *** Bug 49742 has been marked as a duplicate of this bug. *** *** Bug 50982 has been marked as a duplicate of this bug. *** *** Bug 57169 has been marked as a duplicate of this bug. *** *** Bug 47174 has been marked as a duplicate of this bug. *** *** Bug 62074 has been marked as a duplicate of this bug. *** *** Bug 51066 has been marked as a duplicate of this bug. *** *** Bug 64163 has been marked as a duplicate of this bug. *** Wow guys - I've never seen such excellent duplicate solving ! thanks so much to bfoman & ign_christian - you rock ! Since there's so much interest in this issue, I also back-ported it to -4-0 and pushed it there; so closing it now. Thanks Urmas for filing and Sameer for fixing :-) Sameer Deshmukh committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=07a14c901025722bcc0a06c76e83c40985ca01a6&h=libreoffice-4-0 fdo#61060 - Freezing now marks spreadsheet as unsaved. It will be available in LibreOffice 4.0.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thank you so much.. I've been waiting for solution for this bug since very long time ago..:) Hope that Bug 59375 also resolved *** Bug 64706 has been marked as a duplicate of this bug. *** ign_christian: seems you marked a lot of irrelevant issues as duplicates of this bug. This bug is about saving document state after freeze, not a general freeze issue. Please review them once again and reopen as needed if still reproducible in latest stable version. Sorry if I made mistake. I'll review it later with 4.0.4.1 I still can reproduce this bug with XLS file on Bug 62045 LO 4.0.4.1 (Win7 32bit) I'm really sorry again..I didn't read the description carefully. Changing back the status, confirm fixed on LO 4.0.4.1 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.