Bug 61127

Comment on attachment 75121 [details] [review]
build: try harder to avoid systemd/consolekit misconfiguration

Review of attachment 75121 [details] [review]:
-----------------------------------------------------------------

::: configure.ac
@@ +175,4 @@
>    fi
>  fi
>  
> +if test "$have_libsystemd_login" = "yes"; then

These need to be AS_IF().  See https://bugzilla.gnome.org/show_bug.cgi?id=681413

Furthermore, I'd wrap this whole check inside:

AS_IF([test x$cross_compiling != x], [
 ...
])

@@ +179,5 @@
> +  if test ! -d /sys/fs/cgroup/systemd/ ; then
> +    if test "$enable_libsystemd_login" = "yes"; then
> +      AC_MSG_WARN([libsystemd-login requested but system does not appear to be using systemd])
> +    else
> +      AC_MSG_ERROR([libsystemd-login autoconfigured, but system does not appear to use systemd])

This will actually break the gnome-ostree build system which isn't specifying --enable-systemd-login right now, but also doesn't have systemd actually *running* in the buildroot.

I'll fix that now though as a defensive measure.

Created attachment 76607 [details] [review]
build: try harder to avoid systemd/consolekit misconfiguration

(In reply to comment #2)
> Created attachment 76607 [details] [review] [review]
> build: try harder to avoid systemd/consolekit misconfiguration

There was a typo and logic error in the cross compiling detection; since it's either "yes" or "no", we need to if != "yes".  Fixed and pushed to master, thanks!