Bug 61197

bug still exists in mesa-9.1 final

*** Bug 61600 has been marked as a duplicate of this bug. ***

I'm experiencing the same problems after upgrading my Gentoo system from 9.0.1 to mesa 9.1.

system details:

Intel(R) Core(TM)2 Duo CPU P8700 @ 2.53GHz
Mobile 4 Series Chipset Integrated Graphics Controller / GMA 4500MHD ("i915" kernel driver)
Kernel 3.8.2
xf86-video-intel 2.21.3
libdrm 2.4.42
kwin 4.10.1

git bisect bad
60894edeef973e86a73067276f658b72f84271b6 is the first bad commit
commit 60894edeef973e86a73067276f658b72f84271b6
Author: Eric Anholt <eric@anholt.net>
Date:   Thu Jan 10 15:11:28 2013 -0800

    intel: Make intel_region's pitch be bytes instead of pixels.

    We almost never want a stride in pixels -- if you're doing anything with
    a stride, you're specifying an offset or incrementing a pointer, and in
    both cases you had to multiply by cpp to get the bytes value you wanted.
    But worse, on the way to creating a region from a new tiled BO, we
    divided by cpp to get pitch in pixels, and for an RGB32 buffer (an
    upcoming change) the pitch wouldn't divide exactly, and we'd end up with
    a wrong stride in our region.

    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

:040000 040000 20cab1a9079778d75f58a105ae054602117380fd d3c03362f04930e826564ea656b5d511652e6249 M      src

Does it work on Mesa master?  I bet it needs:

commit e062a4187d8ea518a39c913ae7562cf1d8ac3205
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Mon Jan 28 08:53:56 2013 +0200

    intel: Fix regression in intel_create_image_from_name stride handling

I also experienced the same screen corruption on my Ivybridge desktop under mesa 9.1.

Today, I compiled mesa from Anholt's fs-varying-uniform branch (to test a proposed solution for an Ivybridge-specific issue, see bug #61554), which includes the commit suggested by Eric.

kwin_gles now works fine, the corruption is gone.

Shouldn't the mentioned commit be a candidate for mesa 9.1 branch?

it works on SandyBridge too

(In reply to comment #5)
> Does it work on Mesa master?  I bet it needs:
> 
> commit e062a4187d8ea518a39c913ae7562cf1d8ac3205
> Author: Tapani Pälli <tapani.palli@intel.com>
> Date:   Mon Jan 28 08:53:56 2013 +0200
> 
>     intel: Fix regression in intel_create_image_from_name stride handling

Yes. It works on SNB

I added the patch of commit e062a4187d8ea518a39c913ae7562cf1d8ac3205 to regular mesa 9.1 and it's working now.

> Does it work on Mesa master?  I bet it needs:
> 
> commit e062a4187d8ea518a39c913ae7562cf1d8ac3205
> Author: Tapani Pälli <tapani.palli@intel.com>
> Date:   Mon Jan 28 08:53:56 2013 +0200
> 
>     intel: Fix regression in intel_create_image_from_name stride handling

Is there any chance to backport commit to mesa-9.1 branch?

Picked as:

commit a31c9c3fa9e969c52754269240131ea66b7db50e
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Mon Jan 28 08:53:56 2013 +0200

    intel: Fix regression in intel_create_image_from_name stride handling
    
    Strangely, the DRIimage interface we have passes the pitch in pixels
    instead of bytes, which anholt missed in the change to using bytes for
    region pitch.
    
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
    Reviewed-by: Eric Anholt <eric@anholt.net>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61197
    (cherry picked from commit e062a4187d8ea518a39c913ae7562cf1d8ac3205)