| Summary: | [PATCH] sysdeps: Don't use LOG_PERROR if systemd is booted | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Colin Walters <walters> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | chengwei.yang.cn, walters |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| See Also: | https://bugs.freedesktop.org/show_bug.cgi?id=39987 | ||
| Whiteboard: | r+ | ||
| i915 platform: | i915 features: | ||
| Attachments: | [PATCH] sysdeps: Don't use LOG_PERROR if systemd is booted | ||
|
Description
Colin Walters
2013-02-24 14:33:34 UTC
Comment on attachment 75448 [details] [review] [PATCH] sysdeps: Don't use LOG_PERROR if systemd is booted Review of attachment 75448 [details] [review]: ----------------------------------------------------------------- Please tick the "is a patch" box when attaching patches, otherwise Splinter doesn't work. Patch looks good. This was missing a #include "sd-daemon.h", which I've now fixed. Please do a build and "make check" with --enable-developer before merging patches. (In reply to comment #2) > This was missing a #include "sd-daemon.h", which I've now fixed. Please do a > build and "make check" with --enable-developer before merging patches. Odd...it worked locally, and gnome-ostree found the commit and built it about 10 minutes after I pushed. Oh, it's a --enable-developer issue. Yeah, sorry about that =/ Unfortunately my build system isn't yet highlighting compiler warnings for me, need to fix that... |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.