Bug 61609

Summary: [G33 SNA] mplayer2 XV output fullscreen pan/scan "zoom" bugging/corruption
Product: xorg Reporter: Matti Hämäläinen <ccr>
Component: Driver/intelAssignee: Chris Wilson <chris>
Status: RESOLVED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Screenshot of a fullscreen Mplayer2
none
Another screenshot, demonstrating the issue more visibly. none

Description Matti Hämäläinen 2013-02-28 10:49:53 UTC
Created attachment 75683 [details]
Screenshot of a fullscreen Mplayer2

When running MPlayer2 (pretty much the latest from mplayer2 GIT repo), using the XV output, in fullscreen and using the pan/scan "zoom" functionality (via W/E keys), the adjustment does not seem to be working correctly.

Instead of the expected "zooming in" pan/scan, the image shifts right and part of the screen on the left side becomes unupdated/corrupted, as demonstrated in the attached screenshots.

-- Window manager: WindowMaker 0.95.3
-- chipset: 00:02.0 VGA compatible controller: Intel Corporation 82G33/G31
Express Integrated Graphics Controller (rev 10)
-- system architecture: i686 / 32bit
-- xf86-video-intel: GIT a0a2faefdefbea63669dfeb49f7e701196ab5631
-- xserver: X.Org X Server 1.12.4 from Debian testing
-- mesa: 8.0.5-3 from Debian testing
-- libpixman: 0.26.0
-- libdrm version: 2.4.40-1
-- kernel version: 3.8.0 (vanilla from kernel.org)
-- Linux distribution: Debian Testing aka Wheezy
-- Machine or mobo model: Asus P5KPL-CM
-- Display connector: VGA
Comment 1 Matti Hämäläinen 2013-02-28 10:50:34 UTC
Created attachment 75684 [details]
Another screenshot, demonstrating the issue more visibly.
Comment 2 Matti Hämäläinen 2013-02-28 11:25:04 UTC
Using MPlayer2's OpenGL output driver via "-vo gl" works as expected, but XV is generally faster.
Comment 3 Chris Wilson 2013-02-28 11:34:07 UTC
This should (hopefully) be a simple mistake in computing the cropped src/dst window and offsets...
Comment 4 Chris Wilson 2013-02-28 11:59:07 UTC
I've mplayer2 (2.0-554-gf63 from Debian sid), nothing is happening when I press w/e with either xv or gl, fullscreen or windowed.

[w and e: Decrease/increase pan-and-scan range.]

I think you need to dumb down your instructions a bit more :(
Comment 5 Chris Wilson 2013-02-28 12:11:41 UTC
Thanks for the hint for a mismatching aspect ration. I can reproduce this now using sintel.
Comment 6 Matti Hämäläinen 2013-02-28 13:09:16 UTC
Bisected the commit that broke this: 7a4d1136bd09bfd4d2657c0b1b64d553eeb6ed4f
Comment 7 Chris Wilson 2013-02-28 13:27:48 UTC
Heh, that was to fix another instance of cropping ending up in the wrong place.
Comment 8 Chris Wilson 2013-02-28 14:52:44 UTC
Ok, it is just the src-offset that ends up not being scaled correctly.
Comment 9 Chris Wilson 2013-02-28 21:15:46 UTC
commit 89038ddb96aabc4bc1f04402b2aca0ce546e8bf3
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Thu Feb 28 14:35:54 2013 +0000

    sna/video: Correct scaling of source offsets
    
    When applying pan and zoom to a mismatched video, it would inevitably
    miscompute the origin and scale factors.
    
    Reported-by: Matti Hamalainen <ccr@tnsp.org>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61610
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 10 Matti Hämäläinen 2013-03-01 07:26:11 UTC
Confirmed fixed. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.