Bug 61782

Summary:	[gst-vaapi] Some MPEG2 files failed by low ssim value
Product:	libva	Reporter:	Du Yan <yanx.du>
Component:	intel	Assignee:	Zhong Cong <congx.zhong>
Status:	VERIFIED FIXED	QA Contact:	Sean V Kelley <seanvk>
Severity:	normal
Priority:	medium	CC:	ouping.zhang, yanx.du
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	quant-matrix deliver early fix-mpeg2-quant-matrix-bug fix-mpeg2-quant-matrix-bug

Description Du Yan 2013-03-04 08:29:09 UTC

System Environment:
--------------------------
platform: HSW /IVB
libva  staging   522ddedc6d1af7d131e2ba92a0fb1d65c514916f
intel-driver staging  b3139d1a278d9daac40987f0a99c2a797c0db988
gst-vaapi  qa   41940904625f7a3dbdf88d4d1f9fe2df4c434286


Bug Info:
--------------------------
Some MPEG2 files failed by low ssim value

att_mismatch_att.bits
ibm-bw.BITS
sony-ct1.bits
sony-ct2.bits

e.g. ibm-bw.BITS  start from 2nd frame, low ssim

Y_SSIM = 0.787833
U_SSIM = 0.940109
V_SSIM = 0.936272

Y_MIN_SSIM =  0.465200


sony-ct1.bits  start from 41st frame, low ssim

121 Y_SSIM = 0.989385
122 U_SSIM = 0.989829
123 V_SSIM = 0.992725

Y_MIN_SSIM =     0.988699

Comment 1 Zhong Cong 2013-03-11 12:40:56 UTC

Created attachment 76334 [details] [review]
quant-matrix deliver early

the current picture parameter is updated before the current quant-matrix-extension parsed , so the quant-matrix-parameter sent to intel-driver is wrong sometimes.

Comment 2 Zhong Cong 2013-03-11 12:47:39 UTC

sony-ct1.bits still has other issue after adding the patch , i am tring to fix it. the others can not be reproduced.

Comment 3 Zhong Cong 2013-03-12 08:20:07 UTC

Created attachment 76371 [details] [review]
fix-mpeg2-quant-matrix-bug

the new picture use the previous quant matrix extension value, that will cause problem

Comment 4 Zhong Cong 2013-03-12 10:50:19 UTC

Created attachment 76381 [details] [review]
fix-mpeg2-quant-matrix-bug

the current picture parameter is updated before the current quant-matrix-extension parsed , so the quant-matrix-parameter sent to intel-driver is wrong sometimes.
the new picture use the previous quant matrix extension value, that will cause problem.

Comment 5 Jocelyn Li 2013-03-15 14:13:00 UTC

Cong, what is the status for this bug? Can it be marked as Resolved?

Comment 6 Zhong Cong 2013-03-20 01:03:47 UTC

yes. This bug is fixed.

Comment 7 Yang Lianyue 2013-06-03 02:39:00 UTC

test OK. Issue can't be produced. Close it.

Comment 8 Yang Lianyue 2013-06-03 03:04:13 UTC

The case of named "att_mismatch_att.bits" is NG.
It can't be closed.
Please reopened.

Comment 9 Ouping Zhang 2013-06-03 03:25:24 UTC

MPEG2 conformance passed except for att_mismatch_att.bits
refer to bug https://bugs.freedesktop.org/show_bug.cgi?id=61485

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.