Summary: | stderr variable is too generic | ||
---|---|---|---|
Product: | colord | Reporter: | Antoine Jacoutot <ajacoutot> |
Component: | daemon | Assignee: | Richard Hughes <richard> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | OpenBSD | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | stderr -> cd_stderr |
commit e17d3f90a12e6ac002a3b0adb819fe0a88ff86f3 Author: Antoine Jacoutot <ajacoutot@openbsd.org> Date: Tue Mar 5 10:29:33 2013 +0000 Fix build on OpenBSD Resolves: https://bugs.freedesktop.org/show_bug.cgi?id=61842 Signed-off-by: Richard Hughes <richard@hughsie.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 75945 [details] stderr -> cd_stderr Hi. On at least OpenBSD, stderr is defined in <stdio.h> which breaks the build of colord (0.1.30): cd-main.c: In function 'cd_main_generate_profile': cd-main.c:1126: error: expected identifier or '(' before '&' token cd-main.c:1162: error: lvalue required as unary '&' operand cd-main.c:1172: warning: format '%s' expects type 'char *', but argument 5 has type 'struct FILE *' stderr being a very generic name for a variable, would it be possible to rename it to something like cd_stderr? Thank you.