Bug 61868

Summary:	EDITING: highlighter tool displays wrong colour
Product:	LibreOffice	Reporter:	john.pratt
Component:	Writer	Assignee:	Maxim Monastirsky <momonasmon>
Status:	RESOLVED FIXED	QA Contact:	Jorendc <jorendc>
Severity:	minor
Priority:	medium	CC:	momonasmon
Version:	4.0.1.2 release
Hardware:	Other
OS:	All
See Also:	https://bugs.freedesktop.org/show_bug.cgi?id=71413
Whiteboard:	target:4.3.0
i915 platform:		i915 features:

Description john.pratt 2013-03-05 17:12:21 UTC

The highlighter tool can be clicked in the middle to immediately apply the colour shown at the bottom to the selected text.  This does not always work correctly - the colour applied is not what I expect.

Steps
1. Open two blank writer documents
2. Type some text in both documents (doesn't need to be the same text on both)
3. Select some text in document A
4. Use the highlighter toolbar button to apply highlight (click the button - don't open the dropdown).  This applies yellow highlight to the selected text.
5. Select some text in document B
6. Use the highlighter toolbar button dropdown to select a different colour (e.g. green) highlight.  This applies green highlight to the selected text.
7. Select some other text in document A
8. Look at the highlighter button in document A.
9. Use the highlighter toolbar button to apply highlight (click the button - don't open the dropdown)

Actual behaviour: the highlighter button in document A is still yellow, but when clicked (in step 9) the highlight applied is green.

Expected behaviour:
  Either: in step 9 the highlight applied is yellow (preferred solution)
  Or: in step 8 the button is observed to be green (a solution, but not as good)

Comment 1 Jorendc 2013-03-05 18:20:02 UTC

Thanks for reporting!

I can confirm this behavior using LibreOffice Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd325abf1ac077904985) with Linux Mint 14 x64.

> Expected behaviour:
>  Either: in step 9 the highlight applied is yellow (preferred solution)
Agreed with that

I mark this bug as NEW.

Minor: Does not prevent you to make high quality work, does make it a bit harder.
Medium: default priority for minor bugs.

Kind regards,
Joren

Comment 2 Neutrino 2013-09-22 15:06:33 UTC

Confirming that in 4.1.1.2 on Win7 x64 this bug seems to be even worse.

If you have nothing selected then clicking the Highlighting toolbar button changes the cursor to a ‘paint fill’ style cursor. Clicking anywhere in the document or clicking the highlighting toolbar button again reverts the cursor to normal. FIX: More useful behaviour would be for the Highlighting button to just do nothing when there is no selection (wouldn't want to disable the button since you still want to be able to use the dropdown to reconfigure the highlight colour).

Using the drop down on the Highlighting toolbar button to change the highlight colour has the same effect as selecting Highlighting with no selection as described above. Additionally the coloured block under the Highlighting toolbar button that is supposed to display the currently selected highlight colour does not change colour at all. FIX: Changing the highlight colour in this way should just change the highlight colour without activating highlight mode. (Optional) if a highlighted block of text is selected then the block’s colour could also be updated to the new colour.

Comment 3 Maxim Monastirsky 2014-09-04 15:03:30 UTC

Fixed by http://cgit.freedesktop.org/libreoffice/core/commit/?id=584b415924bba22db23a4258062e54973de0ed7c

(In reply to comment #2)
> If you have nothing selected then clicking the Highlighting toolbar button
> changes the cursor to a ‘paint fill’ style cursor.
How is this related to the original bug?

> Additionally the coloured block under the
> Highlighting toolbar button that is supposed to display the currently
> selected highlight colour does not change colour at all.
Also fixed by the above commit.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.