Bug 62112

Summary:	xf86-video-openchrome doesn't work with xorg 1.14
Product:	xorg	Reporter:	Pascal Ernster <bugs.freedesktop.org>
Component:	Driver/openchrome	Assignee:	Openchrome development list <openchrome-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	xavier
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Pascal Ernster 2013-03-10 15:56:01 UTC

xf86-video-openchrome doesn't work with xorg 1.14
because of the formerly deprecated function miInitializeBackingStore() being used  in line 1876 of src/via_driver.c :

http://cgit.freedesktop.org/openchrome/xf86-video-openchrome/tree/src/via_driver.c?id=a925749eb21ba9e2e58845bc91554a09f20322ca

miInitializeBackingStore() has been an empty function anyhow since november 2010, so the line in question can safely be removed:

http://cgit.freedesktop.org/xorg/xserver/commit/mi?id=c4c4676e6874b42c2371eee96faa2c2dbb59a704

I therefore propose the following patch:

diff -rup a/src/via_driver.c b/src/via_driver.c
--- a/src/via_driver.c	2013-03-10 16:11:57.614059200 +0100
+++ b/src/via_driver.c	2013-03-10 16:12:46.374062244 +0100
@@ -1873,7 +1873,6 @@ VIAScreenInit(SCREEN_INIT_ARGS_DECL)
     if (!pVia->NoAccel && !viaInitExa(pScreen))
         return FALSE;
 
-    miInitializeBackingStore(pScreen);
     xf86SetBackingStore(pScreen);
 #if 0
     xf86SetSilkenMouse(pScreen);

Comment 1 Pascal Ernster 2013-03-10 16:16:42 UTC

Oh, I forgot to mention that miInitializeBackingStore() (or rather the whole file  mi/mibstore.c) has been removed from Xorg 1.14:

http://cgit.freedesktop.org/xorg/xserver/commit/mi/mibstore.c?id=056fd15deaa85d3ed936df9a3b2e0cdcfa599da8

This is of course the actual reason for xf86-video-openchrome not working anymore.

Comment 2 boenki 2013-03-19 07:44:36 UTC

I can confirm this patch is working for xserver 1.14
and it's already included in archlinux: https://projects.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/xf86-video-openchrome&id=373e533b4a1da1aff8bcd9e30073bc170c769eb0

Comment 3 Xavier Bachelot 2013-03-21 15:32:36 UTC

Pushed to git master :
http://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=17973712f083100cc041d50fca30e248846e5fd2

Thanks for the patch.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.