| Summary: | Border Values changes on reopening the format cells Widget in impress | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | gokul <gokul.cdac> |
| Component: | Presentation | Assignee: | David Tardon <dtardon> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | a.alharthi, bellgardt, dtardon, fmalotaibi, kaplanlior |
| Version: | 4.0.0.3 release | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | target:4.1.0 target:4.2.0 target:4.0.5 | ||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 54157 | ||
| Attachments: | Steps to reproduce | ||
Bug verified on 4.0.0.3 as well, changing status to new. (In reply to comment #0) > Also, The widget is titled as Format cells, Is it Correct, Should it > not be Format table. Actually format cells is correct, as you get the same dialog for changing the settings for one cell, a few or all of them ("the table"). So actually the "Table..." entry on the right click context menu should be fixed. (In reply to comment #2) > Actually format cells is correct, as you get the same dialog for changing > the settings for one cell, a few or all of them ("the table"). So actually > the "Table..." entry on the right click context menu should be fixed. Changing the string in sd/source/ui/app/popup2_tmpl.src from Table... to Format Cells... would do this. Gokul committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=635f3da03a09213b3d86ced40e7e280cc03d409e Fix related to fdo#62224. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. This is a deadly annoying bug - for sure; I was suffering it editing a table the other night and it's horrible; Gokul's fix will help but is not a full solution I think - I imagine we're populating some SfxItemSets incorrectly here ... (In reply to comment #4) > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=635f3da03a09213b3d86ced40e7e280cc03d409e > > Fix related to fdo#62224. Verified commit, cancel button doesn't change the spacing values any more. The border changes still happens. The cells' attributes only contain the border settings that make sense for them (e.g., the top left cell can only have left or top outer border set, because the bottom and right borders are not outer); see SvxTableController::ApplyBorderAttr(). That means that SvxTableController::MergeAttrFromSelectedCells() would have to reverse that. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=67e87f8b88a5a6a741717cc4a8e64f65f9c9cd52 fdo#62224 reconstruct border state for table dialog The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David Tardon committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=352c89983e108f687c8eed79bdac00c36c641e22&h=libreoffice-4-1 fdo#62224 reconstruct border state for table dialog It will be available in LibreOffice 4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Commit verified, borders looks OK. This still leaves the spacing to contents fields and the synchronize checkbox which don't get the correct values (at the moment all the values are 0 and the checkbox is on). *** Bug 63556 has been marked as a duplicate of this bug. *** I added the distance too. The synchronize checkbox is internal function of the dialog page and its value is not saved anywhere. It is automatically on if all the distances are equal. David Tardon committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=36ecf35102c619b4747fc7ae9af49d4ad052ad8a&h=libreoffice-4-1 fdo#62224 set spacing to content too It will be available in LibreOffice 4.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David Tardon committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=14c139e3705c537556f493657f9cb01818d1f80d fdo#62224 set spacing to content too The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David Tardon committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2839735633dedfcbf2de77180a140eb4bf9a9c2d&h=libreoffice-4-0 fdo#62224 reconstruct border state for table dialog It will be available in LibreOffice 4.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. David Tardon committed a patch related to this issue. It has been pushed to "libreoffice-4-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=58c910eda00d1f3751ac1054ef2fcafe4a90abde&h=libreoffice-4-0 fdo#62224 set spacing to content too It will be available in LibreOffice 4.0.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 76395 [details] Steps to reproduce The Values which we set using Format Cells Widget(Right click on table->table) in impress. If you create an table with n rows and m columns, and then set the table border properties ( Set outer border and all inner lines) and/or line width &/or spacing between contents, The value is set properly. But, If you open the widget again, --> You will see all the inner lines will not be set(if you had selected outer border with all inner lines). --> If you click cancel and then open again You will find the line spacing to changed and also the synchronize will be checked. --> If you click "ok" the table borders will disappear. all lines will be removed and also the spacing between line will be changed and synchronize will be set. Check the Attached image, It describes the steps. Also, The widget is titled as Format cells, Is it Correct, Should it not be Format table.