| Summary: | REPORTBUILDER: multiple groupings on same field broken | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Lionel Elie Mamane <lionel> |
| Component: | Database | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | anthony, iplaw67, libreoffice, robert |
| Version: | 4.1.0.0.alpha0+ Master | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | EasyHack DifficultyInteresting SkillCpp | ||
| i915 platform: | i915 features: | ||
| Attachments: | Shows, how multiple groupings should work (by interval) and what happens with the same group | ||
|
Description
Lionel Elie Mamane
2013-03-12 17:28:14 UTC
Code pointers: File reportdesign/source/filter/xml/xmlExport.cxx function ORptExport::exportGroupsExpressionAsFunction That's where the name is chosen. Need to make it unique somehow. Please choose a naming scheme that is predictable and stable. I mean: - the user that happens to know LibreOffice's implementation details knows what the function name is just from the grouping information - stable: does not change as long as the grouping information does not change Take care that in file reportdesign/source/filter/xml/xmlGroup.cxx function OXMLGroup::OXMLGroup parses back what ORptExport::exportGroupsExpressionAsFunction creates. You need to keep that in sync *but* take care of backwards compatibility! That code needs to be able to parse old files, that is what *old* versions of ORptExport::exportGroupsExpressionAsFunction were creating, as well as new files. Rather than piling up fragility in this parsing, you might want to actually take the occasion to clean up this mess by actually storing the values chosen by the user in the UI directly (in new attributes of the <group> node). See the introduction of sort-expression in commit 4178806bb010129f3b13b62825476666fe48ddcd to see what I mean. For backwards compatibility, if the new clean way is not present, fall back to parsing the group-expression attribute. This situation, i.e. where I attempt to define, e.g. an accumulation function on the same field in both the Group Footer and Detail sections of the report, appears to cause a mutex lock / race condition on Mac OSX, requiring a force kill of the office for all versions I have tested so far : 3.5.7 - beachball requiring force kill 3.6.5.2 - direct SIGABRT 4.0.2.2 - beachball requiring force kill Version 4.1.0.0.alpha0+ (Build ID: 44019e1c9a6b2072c70de121d15ad477e38cacb) Alex Created attachment 84162 [details]
Shows, how multiple groupings should work (by interval) and what happens with the same group
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details Adding self to CC if not already on |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.