Bug 62413

Summary: Don't iterate the default main context
Product: PackageKit Reporter: Giovanni Campagna <scampa.giovanni>
Component: client-libraryAssignee: Richard Hughes <richard>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: lib: don't use the default main context in sync PkClient methods

Description Giovanni Campagna 2013-03-16 14:30:26 UTC 
Using a recursive mainloop for the default context is a bad idea in general, but it's absolutely wrong when the methods are called from a different thread, as many sources installed on the default context (such as all of Gdk/Gtk) expect to be called only from the primary thread.
Comment 1 Giovanni Campagna 2013-03-16 14:31:10 UTC 
Created attachment 76609 [details] [review]
lib: don't use the default main context in sync PkClient methods
Comment 2 Richard Hughes 2013-03-16 17:03:10 UTC 
Applied, thanks!
Comment 3 Richard Hughes 2013-03-16 17:40:40 UTC 
Hmm, this breaks make check. It just hangs.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.