Bug 62595

Summary: Make Edits to Charts Undoable -- Currently Chart Edits Are Not Undoable via Ctrl + Z
Product: LibreOffice Reporter: Clemens Eisserer <linuxhippy>
Component: ChartAssignee: Not Assigned <libreoffice-bugs>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: high CC: jmadero.dev
Version: 4.0.2.1 rc   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Clemens Eisserer 2013-03-21 15:17:26 UTC
The insertion of error bars is not recorded as an edit-event in the history.
When pressing Ctrl+Z to undo the most recent edit operation, the error bars stay in place. Instead the edit operation which was performed before the error bars were inserted is reversed.
Comment 1 Joel Madero 2013-04-17 18:57:35 UTC
This issue is a wider problem than just with error bars, apparently any edits to the chart are not reversible. For instance go into the chart and move the title around, then click out and do ctrl + z, it will not work. 

Changing title, and marking:

New (confirmed)
Enhancement - this isn't a bug per say, it's just never been implemented but it is probably expected to work.

Highest - would benefit anyone using charts, being able to undo changes to charts is very important. I would suspect there are multiple bugs that are basically asking for the same thing and would be solved if this was implemented.


Adding:

Kohei - I know you're overwhelmed but do you have code pointers for this and anyone in mind that might be able to get this done?
Comment 2 Kohei Yoshida (inactive) 2013-04-17 19:24:03 UTC
This is one of the hardest ones even for veteran core developers, and no pointers since I don't even have enough clue to advise others.
Comment 3 Kohei Yoshida (inactive) 2013-04-17 20:09:44 UTC
The only thing I know is that SfxUndoManager is the shared undo manager for all apps, but each app maintain its own undo redo stack.  The chart and calc apps are technically separate "apps" hence calc has no access to chart's undo stack and vise versa.

To fix this, we need to re-architect the current undo mechanism to allow nested undo stacks across multiple apps.  And that's a big task.
Comment 4 Dan Dascalescu 2013-07-01 02:38:00 UTC
At least make the very fact of inserting a chart undoable?

I.e. Insert -> Chart
Ctrl+Z should delete the chart
Comment 5 Joel Madero 2013-07-01 02:46:19 UTC
This is already possible, must click off of the OLE object (chart) and then do ctrl + z, I just did a test and it "deleted" (ie. undid)
Comment 6 Björn Michaelsen 2014-01-17 00:43:53 UTC
(This is an automated message.)

LibreOffice development currently prioritizes bugs with the so called MAB (most annoying bugs) -- as this bug has not run through that process (including writing a short rationale for this bug being a candidate and other who are watching the tracker bug silently approving that rationale etc.) its priority is set to high. Note this is effectively no change in the urgency assigned to this bug, as we are currently not making a difference between high and highest and severity is untouched.

You can find out more about MABs and how the process works by contacting libreoffice qa on irc:

 http://webchat.freenode.net/?channels=libreoffice-qa

The QA wiki page also gives you hints on how to get in contact with the team (if IRC fails you, your next best choice is the mailing list):

 https://wiki.documentfoundation.org/QA

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.