Bug 62681

Summary: [sna 865g] Adobe flash corruption
Product: xorg Reporter: tka <tka>
Component: Driver/intelAssignee: Chris Wilson <chris>
Status: RESOLVED NOTOURBUG QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
backtrace of the failed assertion none

Description tka 2013-03-23 22:33:43 UTC
Created attachment 76953 [details]
backtrace of the failed assertion

The output of Adobe's flash player is heavily corrupted with versions 2.21.4 and 2.21.5 of xf86-video-intel. Flash videos are distorted and shown with wrong colors. Version 2.21.3 is ok.

Bisecting the changes between 2.21.3 and 2.21.4 revealed commit 4174c7bb14ea3428d86dc327950e76d0589e0cc4 (sna: Use depth-15 rather than depth-16 for reduced bw devices) to be the cause of the corruption. Reverting that change on top of the current HEAD (f6582387e7d601272a92c3aaeb656de5ce1ffe75) resolves the issue.

Furthermore, trying to grab a screenshot with a corrupted youtube-video triggered an assertion in kgem_create_buffer_2d (width > 0 && height > 0; see attached backtrace).
Comment 1 Chris Wilson 2013-03-23 23:12:07 UTC
Adobe flash is not my bug, but their notoriously broken swrast.The assertion failure looks to be have been a silly oversight:

Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sat Mar 23 23:08:02 2013 +0000

    sna: Convert out-of-bounds sample to CLEAR
    
    If asked to perform pixelformat conversion of a sample that resides
    outside the valid area, we can simply substitute CLEAR.
    
    Bugzila: http://bugs.freedesktop.org/show_bug.cgi?id=62681
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.