Summary: | [bisected] WebGL demo "Consumed": texstate.c:628: update_texture_state: Assertion „__builtin_popcount(enabledTargets) == 1“ failed. | ||
---|---|---|---|
Product: | Mesa | Reporter: | Pavel Ondračka <pavel.ondracka> |
Component: | glsl-compiler | Assignee: | Kenneth Graunke <kenneth> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | idr |
Version: | git | Keywords: | regression |
Hardware: | Other | ||
OS: | All | ||
URL: | http://playground.christianwannerstedt.com/projects/consumed/ | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 67224 | ||
Attachments: | full backtrace |
Description
Pavel Ondračka
2013-03-24 14:29:00 UTC
I mailed out a Piglit test that reproduces this: http://lists.freedesktop.org/archives/piglit/2013-July/006432.html Doesn't look too hard to fix. I've sent a proposed patch to mesa-dev: http://lists.freedesktop.org/archives/mesa-dev/2013-July/042312.html commit 07cdf426c108eca93ac8ff3c682e2c800a5f5d20 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Thu Jul 25 14:47:58 2013 -0700 mesa: Remove broken assertion about enabled texture targets. For GLSL programs, enabledTargets can have more than one bit set. For example, a shader that uses sampler2D and samplerCube uniforms will have both TEXTURE_2D_BIT and TEXTURE_CUBE_BIT set. The code that sets _ReallyEnabled already handles this, selecting the "highest priority" texture target. We should simply use that. Fixes new Piglit test incomplete-textures-of-multiple-types. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=62698 Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Brian Paul <brianp@vmware.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.