Bug 62699

Summary: drop "pass-through" header files
Product: LibreOffice Reporter: David Tardon <dtardon>
Component: LibreofficeAssignee: Michael <mdunphy>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: bjoern.michaelsen, libreoffice, mdunphy
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard: EasyHack DifficultyBeginner TopicCleanup target:4.1.0 target:4.2.0
i915 platform: i915 features:

Description David Tardon 2013-03-24 14:38:02 UTC
The idea is to drop header files that only include one other header file. What should be done:

1. identify such a header
2. replace all includes of it directly by the included header
3. remove the header from Package_inc.mk of the module (if present)
4. remove the header file
5. lather, rinse, repeat :-)

Example header file is svx/inc/svx/svditext.hxx .
Comment 1 Commit Notification 2013-04-19 08:26:09 UTC
Marcos Paulo de Souza committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f30f805bd87b940fd0693fb9f8c90e6ca779eff

fdo#62699: Drop wrapper header



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2013-04-20 18:20:01 UTC
Michael Dunphy committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=13dcaae519920b0f8a3ad11308117a8f19144580

fdo#62699 Remove pass-through headers



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2013-04-21 05:57:35 UTC
Michael Dunphy committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f4fc74c34df6efd6b74aacc610bf6f52b615aa5

fdo#62699 Remove a few more pass-through headers



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 4 David Tardon 2013-04-25 18:13:45 UTC
*** Bug 63920 has been marked as a duplicate of this bug. ***
Comment 5 Commit Notification 2013-06-28 11:43:15 UTC
Thomas Arnhold committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ab3f90e051256bbf0d999551fedb5106d0367d3a

fdo#62699 remove pass-through header



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2013-06-28 11:43:33 UTC
Thomas Arnhold committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=61fd1d2e7803516e88a18017ee5d6a34d6ca14fa

fdo#62699 remove rsc/inc/vclrsc.hxx



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2013-07-02 09:00:32 UTC
Thomas Arnhold committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=10c6cb238f0ae5d5969ffd0012bf23305ac5894f

fdo#62699 drop pass-through header svx/svdattrx.hxx



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Björn Michaelsen 2013-10-04 18:46:18 UTC
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 9 Thomas Arnhold 2013-10-05 10:30:19 UTC
Lot of work was done, and if I remember correctly most are eliminated.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.