Bug 62871

Summary:	weston kms unit test execution broken due to using weston-launch
Product:	Wayland	Reporter:	Joe Konno <joe.konno>
Component:	weston	Assignee:	Wayland bug list <wayland-bugs>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	brian.j.lovin, ullysses.a.eoff
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	execute DRM tests using weston-launch instead of weston.

Description Joe Konno 2013-03-28 16:09:42 UTC

http://cgit.freedesktop.org/wayland/weston/commit/?id=32069c09eab9547db3f023fc515e4eba2778efca

weston-tests-env, potentially others, assumes the same executable (weston) is required for unit test execution. The commit noted above changed the procedure for weston-kms-- for valid reasons.

The unit tests just need to catch up to the new procedure.

Comment 1 Joe Konno 2013-03-28 16:27:41 UTC

False alarm, non-issue. Manually running 'make check' on a running weston instance, however it's launched, works fine.

Comment 2 Brian Lovin 2013-03-28 23:03:48 UTC

This is a bug - it can be resolved with an easy patch; but it opens up another bug as an issue to running the unit tests: bug #61877

Each unit test attempts to run the approximate equivalent of the following:

WESTON_TEST_CLIENT_PATH=$SOMEPATH/button-test weston --modules=$SOMEPATH/.libs/weston-test.so

The patch changes this to be:
WESTON_TEST_CLIENT_PATH=$SOMEPATH/button-test weston-launch -- --modules=$SOMEPATH/.libs/weston-test.so

The WESTON_TEST_CLIENT_PATH var doesn't get passed to Weston and the test is never run. (bug #61877)

Comment 3 Brian Lovin 2013-03-28 23:08:36 UTC

Created attachment 77175 [details]
execute DRM tests using weston-launch instead of weston.

Comment 4 Kristian Høgsberg 2013-10-31 05:43:49 UTC

I'll close this one now as we have support for logind in master, which lets us run the test suite with just weston on the drm backend.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.