Summary: | UI: Section write protection error message is confusing | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Markus Ilmola <markus.ilmola> |
Component: | Writer | Assignee: | Joel Madero <jmadero.dev> |
Status: | REOPENED --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | low | CC: | jmadero.dev, stanislav.horacek |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | BSA target:4.4.0 target:4.5.0 target:4.4.0.0.beta3 | ||
i915 platform: | i915 features: |
Description
Markus Ilmola
2013-03-28 18:43:57 UTC
This bug seems also been reported to Apache OOO bug tracker: https://issues.apache.org/ooo/show_bug.cgi?id=27678 Verified: Ubuntu 14.04 x64 LibreOffice 4.4 master built a few days ago Sure seems fine. Marking as NEW Enhancement Lowest NeedDevEval (really easy to fix, code pointer I'm sure would be easy to find) Nevermind I just committed a patch - no need for code pointers Joel committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2b7c7fab14ce73dd04d636af05ee837ea7de8f23 fdo#62879 Changed wording of protected section dialog The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. In that patch, “Write protected” is a compound adjective. Shouldn’t it be written hyphenated, for clarity?: “Write-protected sections cannot be changed.” I suppose so - I'll set this to reopened until I submit a follow up patch. This has been pushed and should be in 4.4. Joel committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8cdcea2689600ef16829a3f951ddf6fb8e9125a0 fdo#62879 Hyphenation It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Reopening - I think this change should be reverted as the dialog and the "corrected" message are not specific for sections. Try e.g. this: 1. In a new text document, choose Insert - Frame. 2. On the Options tab, check the Content box in the Protect area and press OK. 3. Try to write inside the new frame. You will see the dialog with the "Write-protected sections cannot be changed" which is clearly wrong here since not section, but frame is involved. Patch changing word "sections" to "content" submitted to Gerrit: https://gerrit.libreoffice.org/#/c/13347/ https://gerrit.libreoffice.org/#/c/13348/ Stanislav Horacek committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=7662c42d1b901d6cfc44f2be3741c349117be520 related fdo#62879 replace "section" in dialog for read-only content It will be available in 4.5.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Stanislav Horacek committed a patch related to this issue. It has been pushed to "libreoffice-4-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=19bef5f451c49a5d3377fd0c0ff4fb92db0d8446&h=libreoffice-4-4 related fdo#62879 replace "section" in dialog for read-only content It will be available in 4.4.0.0.beta3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.