Bug 62883

Summary: draw/draw_gs.c:684:4: error: implicit declaration of function 'draw_get_option_use_llvm' [-Werror=implicit-function-declaration]
Product: Mesa Reporter: Vinson Lee <vlee>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: medium CC: zackr
Version: gitKeywords: regression
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: patch to test

Description Vinson Lee 2013-03-28 22:08:54 UTC
mesa: 9ad914191716631169427f44e08078812ce38ff8

$ ./autogen.sh --with-dri-drivers= --with-gallium-drivers=svga,swrast --enable-gallium-llvm=no
[...]
$ make
[...]
  CC     draw/draw_gs.lo
In file included from draw/draw_gs.c:28:0:
draw/draw_gs.h:136:41: warning: 'struct draw_gs_llvm_variant' declared inside parameter list [enabled by default]
draw/draw_gs.h:136:41: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
draw/draw_gs.c: In function 'draw_create_geometry_shader':
draw/draw_gs.c:684:4: error: implicit declaration of function 'draw_get_option_use_llvm' [-Werror=implicit-function-declaration]
draw/draw_gs.c: At top level:
draw/draw_gs.c:803:41: warning: 'struct draw_gs_llvm_variant' declared inside parameter list [enabled by default]
draw/draw_gs.c:802:6: error: conflicting types for 'draw_gs_set_current_variant'
draw/draw_gs.h:135:6: note: previous declaration of 'draw_gs_set_current_variant' was here
draw/draw_gs.c: In function 'draw_gs_set_current_variant':
draw/draw_gs.c:805:10: error: 'struct draw_geometry_shader' has no member named 'current_variant'
cc1: some warnings being treated as errors

e96f4e3b853ff5fe4d927c69695c0b5f1966d448 is the first bad commit
commit e96f4e3b853ff5fe4d927c69695c0b5f1966d448
Author: Zack Rusin <zackr@vmware.com>
Date:   Mon Feb 18 04:00:19 2013 -0800

    gallium/llvm: implement geometry shaders in the llvm paths
    
    This commits implements code generation of the geometry shaders in
    the SOA paths. All the code is there but bugs are likely present.
    
    Signed-off-by: Zack Rusin <zackr@vmware.com>
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: José Fonseca <jfonseca@vmware.com>

:040000 040000 3e402aa649d27d70f4b2a1481038737873d81982 23436fbded4ca6db7db3c45a4fa47b0bc203190b M	src
bisect run success
Comment 1 Brian Paul 2013-03-28 22:48:12 UTC
Created attachment 77174 [details] [review]
patch to test

Can you try this patch?
Comment 2 Vinson Lee 2013-03-28 22:57:35 UTC
Attachment 77174 [details] fixes the build error.

Tested-by: Vinson Lee <vlee@freedesktop.org>
Comment 3 Brian Paul 2013-03-28 23:18:08 UTC
Fixed with commit 499aa3ddb448a7461c0bdea93c8f218db6992720

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.