| Summary: | FILEOPEN: crash when reading a certain docx | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | oliver.sander |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED WORKSFORME | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | cedric.bosdonnat.ooo, mst.fdo, oliver.sander, serval2412 |
| Version: | 4.0.2.1 rc | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
File that causes the crash
The gdb backtrace console + bt with symbols on master sources |
||
Created attachment 77486 [details]
The gdb backtrace
Comment on attachment 77485 [details]
File that causes the crash
Mimetype fixed
Created attachment 77500 [details]
console + bt with symbols on master sources
On pc Debian (testing updated today) x86-64 with master sources updated today, I reproduced the crash.
I attached the bt (the same as reporter's + few details) + console logs
Cédric/Michael: one for you? After having searched in git history of sw/source/core/unocore/unotext.cxx, I found this commit: d0cde9640b52ccfbb28ed1f65bba0927afd7b69b (2013/02/20), Cédric definitely for you? :-P Adding some traces, "pEndStartTableNode" is NULL after line 1628
diff --git a/sw/source/core/unocore/unotext.cxx b/sw/source/core/unocore/unotext.cxx
index 8d3b8c9..c3ffd05 100644
--- a/sw/source/core/unocore/unotext.cxx
+++ b/sw/source/core/unocore/unotext.cxx
@@ -1626,7 +1626,7 @@ throw (lang::IllegalArgumentException, uno::RuntimeException)
SwTableNode * pStartTableNode(pStartStartNode->FindTableNode());
// Is it the same table start node than the end?
SwTableNode *const pEndStartTableNode(pEndStartNode->FindTableNode());
- while (pEndStartTableNode->GetIndex() < pStartTableNode->GetIndex())
+ while (pEndStartTableNode && (pEndStartTableNode->GetIndex() < pStartTableNode->GetIndex()))
{
SwStartNode* pStartStartTableNode = pStartTableNode->StartOfSectionNode();
pStartTableNode = pStartStartTableNode->FindTableNode();
prevents from the crash but perhaps it should need more things.
Anyway, if you think I can push this patch on master, just tell me.
LO v4.1.3.2 Build ID: 70feb7d99726f064edab4605a8ab840c50ec57a under GNU/Linux Crunchbang 11 opens the attachment in the description without crashing. Thank you Owen for your feedback. On pc Debian x86-64 with 4.1 sources updated 1 week ago, I don't reproduce this anymore. I put it as WFM. ssander: if you still reproduce this with 4.1.3 version, don't hesitate to reopen this tracker. I confirm that it works now. Thank you very much! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 77485 [details] File that causes the crash LibreOffice crashes when opening a certain docx file. I start LO from the command line with the file as the argument. The splash screen appears briefly, and then the program terminates. I'll attach the file and a gdb backtrace. This is with version 4.0.2~rc2-2 from today's Debian experimental.