| Summary: | log iter segfault dereferencing a date empty events next_event | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Alban Browaeys <prahal> |
| Component: | logger | Assignee: | Telepathy bugs list <telepathy-bugs> |
| Status: | RESOLVED INVALID | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | major | ||
| Priority: | medium | ||
| Version: | git master | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
log-iter: skip to next date if the selected one has no events.
empathy-chat: do not disable scrollback for rooms (irc and alike). |
||
|
Description
Alban Browaeys
2013-04-12 09:12:49 UTC
Comment on attachment 77852 [details] [review] log-iter: skip to next date if the selected one has no events. Review of attachment 77852 [details] [review]: ----------------------------------------------------------------- This can only happen if _tpl_log_store_get_dates returns a date for which there are no events. Right? Does that really happen unless the logs have been messed with? As far as I understand, _tpl_log_store_get_dates should only return dates for which there is a valid event. So _tpl_log_store_get_events_for_date should never return NULL for a date that was returned by _tpl_log_store_get_dates. Created attachment 91846 [details] [review] empathy-chat: do not disable scrollback for rooms (irc and alike). I have scrollback enabled for chatrooms in empathy as exhibited in attached patch (not yet submitted to empathy bug tracker). Though I reverted the next_event telepathy-logger previous hack and all looks fine as of now so I will mark it to fixed invalid. The steps to reproduce were to scroll back: scroll the chat window up , the previous events were prepended but somewhat it was segfaulting. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.