Bug 63540

Summary: In the "Authenticate"-message a field named "n" is referenced, but not defined.
Product: XStandards Reporter: Florian Kutscherauer <florian.kutscherauer>
Component: ProtocolAssignee: Jim Gettys <jg>
Status: RESOLVED NOTABUG QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium    
Version: X11R6.6   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Florian Kutscherauer 2013-04-15 06:50:50 UTC
In the "Authenticate"-message (in xproto/specs/encoding.xml, lines 835--842) a field named "n" is referenced thrice: first in "length in 4-byte units of 'additional data'", second in "reason", and third in "unused"; but it is never defined.

I guess it should be identical to "length of reason in bytes" in the "Failed"-message (xproto/specs/encoding.xml, line 823).
Comment 1 Alan Coopersmith 2013-04-15 15:10:57 UTC
It is defined:
     n     STRING8           reason

It is not separately encoded in the response the way it is in the failed
response - I don't know why that is.
Comment 2 Florian Kutscherauer 2013-04-15 20:42:15 UTC
It appears like such a message is never sent by the server.  At least X.org's X server sends a "Failed" message when a client is unauthorized:

In "ProcEstablishConnection" (xserver/dix/dispatch.c, line 3636) "ClientAuthorized" is called which returns a non-NULL pointer if authorization fails.  Later in "SendConnSetup" (on line 3539) this pointer is checked and, if it isn't NULL, a "Failed" message is sent to the client.

That's probably why nobody cares about the "Authenticate"-message any more: it's not being used.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.