Bug 6375

Summary: Israel si1452 => Israel basic
Product: xkeyboard-config Reporter: Amnon A <amnonaar>
Component: GeneralAssignee: xkb
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: high CC: sndirsch
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: patch to symbols/il

Description Amnon A 2006-03-24 22:18:00 UTC
The Israel si1452 layout (defined in symbols/il) is just Israel basic layout
with additional 3rd level definitions for diacritics,  so it seems reasonable to
add these definitions  to the basic layout and remove the si1452 layout.
Comment 1 Sergey V. Udaltsov 2006-03-25 05:45:30 UTC
Could you please provide a patch so we would not get into "fix-test" cycle?
Comment 2 Amnon A 2006-03-25 22:33:27 UTC
Created attachment 5053 [details] [review]
patch to symbols/il

I tested it and it works. However, I'm not sure that the syntax is strictly
correct (especially the key.type assignment in the middle of the layout).
Comment 3 Sergey V. Udaltsov 2006-03-26 01:33:59 UTC
Committed. Moved si1452 to the compat rules.
Comment 4 Stefan Dirsch 2007-05-12 09:02:49 UTC
One of our openSUSE customer has a concern about this change:

"The symbol "|" cannot be produced with Israeli (Hebrew) keyboard (supposed to
be done with shift + backslash). This is due to change in the file defining the keyboard map: /usr/share/X11/xkb/symbols/il

SOLUTION: use the SUSE 10.1 file, or just add:
 key <BKSL> { [ backslash,    bar             ]       };
in line 50 of the above file."

https://bugzilla.novell.com/show_bug.cgi?id=273712
Comment 5 Sergey V. Udaltsov 2007-05-12 10:47:50 UTC
Stefan, there is a line already:

key <BKSL> { [ backslash,    backslash,  0x10005bb  ]}; // Qubuts

Should it be replaced with the line you propose? Any potential damage?
Comment 6 Stefan Dirsch 2007-05-12 10:57:17 UTC
The reporter thinks so, but I would like to hear a comment by Amnon first. I don't think he did his patch just for fun and to annoy users ...
Comment 7 Piter PUNK 2007-05-12 23:40:36 UTC
(In reply to comment #5)
> Stefan, there is a line already:
>
> key <BKSL> { [ backslash,    backslash,  0x10005bb  ]}; // Qubuts
>
> Should it be replaced with the line you propose? Any potential damage?
>

Hi Sergey,

I think the best here is to change only the second "backslash" to "bar"
making:

key <BKSL> { [ backslash, bar, 0x10005bb ] }; // Qubuts

All Israeli keyboard layouts that i found *with* BKSL key have
backslash and bar. You can see it in:

http://en.wikipedia.org/wiki/Hebrew_keyboard
http://docs.sun.com/source/805-4123/images/HebrewKeyboard.epsi.gif
http://www-306.ibm.com/software/globalization/topics/keyboards/KBD212.jsp
http://www.valschuman.com/tools/hebrew_keyboard/keyboard.html

And finally:

http://www.yairgil.com/ksp/bk-ground.jpg

A photo from a real keyboard -:)
Probably that "backslash, backslash" is only a minor mistake, that needs to be fixed.
Comment 8 Amnon A 2007-05-13 01:22:07 UTC
Yes, the second backslash was probably a mistake.  See http://culmus.sourceforge.net/si1452.html
Comment 9 Sergey V. Udaltsov 2007-05-13 04:23:41 UTC
Great! Thanks to everyone, fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.