Bug 6395

Hello,

steps to reproduce:

1) start hal-device-manager
2) insert a floppy into fd0
3) execute mount /media/floppy0
4) as seen by the hal-device-manager output, nothing happens, i.e. device 
state does not change neither a new volume gets added. --verbose=yes output 
reveales, that blockdev.c:blockdev_refresh_mount_state does not find a volume 
for floppy:

20:44:40.171 [I] blockdev.c:214: * found mounts dev /dev/fd0 (2:0)
20:44:40.171 [I] blockdev.c:225:   
match /org/freedesktop/Hal/devices/volume_uuid_E8C2_7995 (8:17)
20:44:40.171 [I] blockdev.c:225:   
match /org/freedesktop/Hal/devices/volume_uuid_4074A19974A19268 (8:7)
20:44:40.171 [I] blockdev.c:225:   
match /org/freedesktop/Hal/devices/volume_uuid_f0dead24_1832_4e65_81ee_864bbe26d00a 
(8:5)
20:44:40.171 [I] blockdev.c:225:   
match /org/freedesktop/Hal/devices/volume_part4_size_1024 (8:4)
20:44:40.171 [I] blockdev.c:225:   
match /org/freedesktop/Hal/devices/volume_label_Movies (22:64)
20:44:40.171 [I] blockdev.c:252: 
set /org/freedesktop/Hal/devices/volume_uuid_E8C2_7995 to unmounted
20:44:40.171 [I] blockdev.c:252: 
set /org/freedesktop/Hal/devices/volume_uuid_4074A19974A19268 to unmounted
20:44:40.171 [I] blockdev.c:252: 
set /org/freedesktop/Hal/devices/volume_uuid_f0dead24_1832_4e65_81ee_864bbe26d00a 
to unmounted
20:44:40.171 [I] blockdev.c:252: 
set /org/freedesktop/Hal/devices/volume_part4_size_1024 to unmounted
20:44:40.171 [I] blockdev.c:252: 
set /org/freedesktop/Hal/devices/volume_label_Movies to unmounted
 
As per http://lists.freedesktop.org/archives/hal/2004-June/000470.html, "we 
only put a child to the top-level block device if it is mounted." But this 
does not happen. As a result, we have such bugs as 
http://bugs.kde.org/show_bug.cgi?id=120619 Relevant code on 
http://websvn.kde.org/branches/KDE/3.5/kdebase/kioslave/media/mediamanager/halbackend.cpp?rev=495057&view=markup 
function void HALBackend::setFloppyProperties(Medium* medium). IIRC, hal 0.4.8 
worked fine with this code.

I'm not a KDE developer neither I have experience with HAL developement. 
However, monitoring hal events I suspect that the problem is a regression in 
hal 0.5.7 (or whole 0.5.x series; at least I don't remember it working with 
any 0.5.x version debian unstable had) rather than the bug in KDE code.

Distribution: Debian unstable (kernels 2.6.15-1-amd64-k8 and 
2.6.16-1-amd64-k8)
ii  dbus                             0.61-4
ii  hal                              0.5.7-1
ii  udev                             0.087-1

Relevant lshal output:

udi = '/org/freedesktop/Hal/devices/platform_floppy_0'
  info.udi = '/org/freedesktop/Hal/devices/platform_floppy_0'  (string)
  linux.subsystem = 'platform'  (string)
  linux.hotplug_type = 1  (0x1)  (int)
  info.product = 'Platform Device (floppy.0)'  (string)
  platform.id = 'floppy.0'  (string)
  info.parent = '/org/freedesktop/Hal/devices/computer'  (string)
  info.bus = 'platform'  (string)
  linux.sysfs_path_device = '/sys/devices/platform/floppy.0'  (string)
  linux.sysfs_path = '/sys/devices/platform/floppy.0'  (string)

udi = '/org/freedesktop/Hal/devices/platform_floppy_0_storage'
  volume.mount.valid_options = {'ro', 'sync', 'dirsync', 'noatime', 
'nodiratime', 'noexec', 'quiet', 'utf8', 'shortname=', 'codepage=', 
'iocharset=', 'umask=', 'uid='} (stringlist)
  org.freedesktop.Hal.Device.Volume.method_execpaths = 
{'hal-system-storage-mount', 'hal-system-storage-unmount', 
'hal-system-storage-eject'} (string list)  
org.freedesktop.Hal.Device.Volume.method_signatures = {'ssas', 'as', 'as'} 
(string list)
  org.freedesktop.Hal.Device.Volume.method_names = {'Mount', 'Unmount', 
'Eject'} (string list)
  info.interfaces = {'org.freedesktop.Hal.Device.Volume'} (string list)
  block.storage_device = 
'/org/freedesktop/Hal/devices/platform_floppy_0_storage'  (string)
  info.udi = 
'/org/freedesktop/Hal/devices/platform_floppy_0_storage'  (string)
  info.capabilities = {'storage', 'block'} (string list)
  info.category = 'storage'  (string)
  storage.requires_eject = false  (bool)
  storage.hotpluggable = false  (bool)
  storage.removable = true  (bool)
  storage.physical_device = 
'/org/freedesktop/Hal/devices/platform_floppy_0'  (string)
  storage.drive_type = 'floppy'  (string)
  info.product = 'PC Floppy Drive'  (string)
  info.vendor = ''  (string)
  storage.vendor = 'PC Floppy Drive'  (string)
  storage.model = ''  (string)
  storage.automount_enabled_hint = true  (bool)
  storage.media_check_enabled = false  (bool)
  storage.no_partitions_hint = true  (bool)
  storage.bus = 'platform'  (string)
  block.is_volume = false  (bool)
  block.minor = 0  (0x0)  (int)
  block.major = 2  (0x2)  (int)
  block.device = '/dev/fd0'  (string)
  linux.hotplug_type = 3  (0x3)  (int)
  info.parent = '/org/freedesktop/Hal/devices/platform_floppy_0'  (string)
  linux.sysfs_path_device = '/sys/block/fd0'  (string)
  linux.sysfs_path = '/sys/block/fd0'  (string)