Bug 64096

Summary:	LLVM RV790 etqw regression since R600: Packetize instructions
Product:	Mesa	Reporter:	Andy Furniss <adf.lists>
Component:	Drivers/Gallium/r600	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	vljn
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Disable bank_swizzle Prevent PV on trans inst Rework PV

Description Andy Furniss 2013-04-30 22:05:59 UTC

rv790 with etqw getting a green tint in levels on current llvm/mesa heads.

llvm bisected to below, while actually sitting on that there are more corruptions than just the tint.

commit 25f259cde28860ea76c2f5628010968945a28edb
Author: Vincent Lejeune <vljn@ovi.com>
Date:   Tue Apr 30 00:14:27 2013 +0000

    R600: Packetize instructions
    
    git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@180760 91177308-0d34-0410-b5e6-96231b3b80d8

Comment 1 Andy Furniss 2013-04-30 22:39:55 UTC

Testing further some of the mesa demos are also wrong - not that I have re- bisected, just assume same issue, on heads -

gloss = blank.

gears, fbo_firecube, gearbox = too dark.

shadowtex = shadow misaligned

Comment 2 vincent 2013-05-01 14:09:35 UTC

Created attachment 78720 [details] [review]
Disable bank_swizzle

Hi,

there is a bug that makes mesa change bank_swizzle if they are provided by backend,
can you apply this patch on top of "R600: Packetize instructions" commit and see if you can bisect further ?

Comment 3 Andy Furniss 2013-05-02 08:56:09 UTC

(In reply to comment #2)
> Created attachment 78720 [details] [review] [review]
> Disable bank_swizzle
> 
> Hi,
> 
> there is a bug that makes mesa change bank_swizzle if they are provided by
> backend,
> can you apply this patch on top of "R600: Packetize instructions" commit and
> see if you can bisect further ?

The patch doesn't change anything.

Comment 4 vincent 2013-05-02 14:49:23 UTC

Created attachment 78783 [details] [review]
Prevent PV on trans inst

Hi,

does this patch help ? (on head)

Comment 5 vincent 2013-05-02 16:38:20 UTC

Created attachment 78786 [details] [review]
Rework PV

Sorry, I tested previous patch and it didn't work.

However this new patch should fix gears, and probably others tests too.
(Apply it on HEAD)

Comment 6 Andy Furniss 2013-05-02 18:32:18 UTC

(In reply to comment #5)
> Created attachment 78786 [details] [review] [review]
> Rework PV
> 
> Sorry, I tested previous patch and it didn't work.
> 
> However this new patch should fix gears, and probably others tests too.
> (Apply it on HEAD)

It fixes the demos and etqw for me.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.