Bug 642

Summary:	#f and () are not distinguished properly
Product:	UIM	Reporter:	YamaKen <yamaken>
Component:	generic Scheme codes	Assignee:	uim-bugs
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
URL:	http://lists.sourceforge.jp/mailman/archives/anthy-dev/2004-May/000830.html
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:	7163
Bug Blocks:	617, 7164

Description YamaKen 2004-05-19 17:49:08 UTC

Currently uim's Scheme interpreter does not distinguish between #f and (). This
is preventing some kind of codes from being written in ordinary way (see bug
#617) and is confusing advanced users who know Scheme.

The patch attached to the URL (by Kouhei Sutou-san) makes siod distinguish
between #f and (). But many Scheme codes under scm directory are not
distinguishing between the ones, so the patch introduces new bugs.

Sanitize all scm files is required. Developers, declare "I have start validating
this file" and do it.

- unchecked files
im.scm
rk.scm
japanese.scm
generic.scm
key.scm
anthy.scm
skk.scm
skk-editor.scm
prime.scm
pyload.scm
hangul.scm
tcode.scm
tutcode.scm
canna.scm
m17nlib.scm
hk.scm
viqr.scm
ipa.scm
spellcheck.scm

- safe files
util.scm
custom.scm
uim-sh.scm
PY.scm
generic-key.scm
hangul2.scm
hangul3.scm
japanese-azik.scm
japanese-kana.scm
latin.scm
loader.scm
default.scm
pinyin-big5.scm
pyunihan.scm
romaja.scm
zaurus.scm

Comment 1 TOKUNAGA Hiroyuki 2004-05-21 00:29:51 UTC

Is there a good way to validate the scm files? Or we have to check whole lines 
with eyes?

Comment 2 Yusuke TABATA 2004-05-21 01:01:04 UTC

Test relevant input method with Suto-san's patch. You will find something wrong
and investigate the probelm with (print "here") way.

Currently, I suppose rk.scm and uim-util.c is the blocker.

Comment 3 Yusuke TABATA 2004-05-22 17:02:07 UTC

I experimentally changed string_equal to return #f.
But define-key'ed predicate does not work properly.

Yamaken-san, could you investigate key.scm?

Comment 4 YamaKen 2004-05-24 07:39:54 UTC

(In reply to comment #3)
> I experimentally changed string_equal to return #f.
> But define-key'ed predicate does not work properly.
> 
> Yamaken-san, could you investigate key.scm?

Okay. Wait for a while.

Comment 5 YamaKen 2004-05-25 23:22:53 UTC

(In reply to comment #4)
key.scm is probably safe. Use test-key.scm to validate the file.
I'm now merging Sutou-san's patch into im.scm and applying further fix.

Comment 6 YamaKen 2004-05-26 06:51:44 UTC

I've checked some files.

- checked
key.scm (test-ready)
im.scm (almost safe and test-ready)
ipa.scm
viqr.scm
tcode.scm
pyload.scm
hangul.scm

- unchecked yet
uim-util.c
uim-func.c
rk.scm
japanese.scm
generic.scm
anthy.scm
skk.scm
skk-editor.scm
prime.scm
canna.scm
tutcode.scm
m17nlib.scm
hk.scm
spellcheck.scm

Comment 7 YamaKen 2004-07-12 01:53:35 UTC

I've checked and fixed a file. See svn r983.

- checked
uim-func.c

- unchecked yet
uim-util.c (almost checked and unit test has been written)
rk.scm
japanese.scm
generic.scm
anthy.scm
skk.scm
skk-editor.scm
prime.scm
canna.scm
tutcode.scm
m17nlib.scm
hk.scm
spellcheck.scm

Comment 8 YamaKen 2004-07-12 03:20:16 UTC

I've checked and fixed a file. See svn r985. Unit test for the procedures are
also available.

- checked
uim-util.c

- unchecked yet
rk.scm
japanese.scm
generic.scm
anthy.scm
skk.scm
skk-editor.scm
prime.scm
canna.scm
tutcode.scm
m17nlib.scm
hk.scm
spellcheck.scm

Comment 9 YamaKen 2006-06-09 00:58:47 UTC

It should be resolved in uim 1.3.0 by disabling SIOD-compatible mode.

Comment 10 YamaKen 2007-07-22 09:33:34 UTC

Resolved by SigScheme with --disable-compat-siod-bugs.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.