Bug 64319

Summary: Self vcard can have fields not in supported fields
Product: Telepathy Reporter: Xavier Claessens <xclaesse>
Component: gabbleAssignee: Telepathy bugs list <telepathy-bugs>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium CC: will
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://cgit.collabora.com/git/user/xclaesse/telepathy-gabble.git/log/?h=google-vcard
Whiteboard:
i915 platform: i915 features:

Description Xavier Claessens 2013-05-07 13:13:46 UTC
For some reason, my Google self vcard has an "url" field and gabble claims it is not supported (missing from SupportedFields property).
Comment 1 Xavier Claessens 2013-05-07 13:23:18 UTC
Ok, this is because gabble hardcodes the fields supported by google in gabble_vcard_manager_can_use_vcard_field() and now google decided to add 'url'.
Comment 3 Will Thompson 2013-05-07 13:53:21 UTC
There's a comment right above the condition which stops being true as of this patch.
Comment 4 Xavier Claessens 2013-05-07 14:08:48 UTC
Yep, fixed that and amended the commit, it's just a matter of cgit being slow to refresh... ;-)
Comment 5 Simon McVittie 2013-05-07 14:11:20 UTC
Ship it.

In future, if you only have a single commit, linking to the commit (including its SHA1) will mean you don't have to worry about whether cgit still has old cached data.
Comment 6 Xavier Claessens 2013-05-07 14:16:16 UTC
ok merged in master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.