| Summary: | Should not claim X-TELEPATHY-PASSWORD mech is supported if username is unknown | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Xavier Claessens <xclaesse> |
| Component: | tp-spec | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | normal | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | review? | ||
| i915 platform: | i915 features: | ||
| Attachments: | X-TELEPATHY-PASSWORD is not mandatory if unimplementable | ||
|
Description
Xavier Claessens
2013-05-08 11:13:17 UTC
Should we also change telepathy-spec? At the moment it says
> To make it possible to implement a very simple
> password-querying user interface without knowledge of any
> particular SASL mechanism, implementations of this interface
> MUST implement the pseudo-mechanism X-TELEPATHY-PASSWORD,
> unless none of the available mechanisms use a password at all.
This should probably be "... unless each of the available mechanisms either requires additional information beyond the password (such as a username), or does not use a password".
Patch looks good, though. Patch merged. Reassigning the bug to spec if someone cares :) Created attachment 91602 [details] [review] X-TELEPATHY-PASSWORD is not mandatory if unimplementable Gabble (correctly) doesn't implement it if you use { "account": "gmail.com" }, which is not enough for X-TELEPATHY-PASSWORD: a mechanism that provides a username, such as PLAIN or Google's OAuth dialect, must be used here. --- I suggested spec text > 6 months ago. Here it is as a patch. Comment on attachment 91602 [details] [review] X-TELEPATHY-PASSWORD is not mandatory if unimplementable Review of attachment 91602 [details] [review]: ----------------------------------------------------------------- ++ Fixed in git for 0.27.4 and 0.99.12, thanks |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.