Bug 64869

Summary:	TpBasePasswordChannel does not wait to see if server accepts the password before claiming success
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	mardy
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Xavier Claessens 2013-05-22 15:02:36 UTC

Steps:
1) create a yahoo account with wrong password into UOA
2) put that account online
3) see that account fails to connect but UOA is not asking user to re-type the password

What happens:
When tp-haze wants to connect, it uses TpBasePasswordChannel to get a password via the SASL system. empathy-auth-client then catch the channel and call StartWithData with the password stored in UOA. The tp_base_password_channel_start_mechanism_with_data() unconditionally moves status to TP_SASL_STATUS_SERVER_SUCCEEDED instead of actually giving the password to the server and move status to TP_SASL_STATUS_SERVER_SUCCEEDED/FAILED depending on the result.

Comment 1 Xavier Claessens 2013-05-22 15:07:41 UTC

What is supposed to happen is SASL channel status moves to TP_SASL_STATUS_SERVER_FAILED and in that case empathy-auth-client tells UOA that the password/token did not work and it will ask user to re-type password or re-grant access.

Comment 2 GitLab Migration User 2019-12-03 20:41:36 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/112.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.