| Summary: | [HSW Bisected] lots of transform_feedback tests fail | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Kenneth Graunke <kenneth> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | daniel, eric, idr, xunx.fang |
| Version: | git | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
lu hua
2013-05-23 01:51:18 UTC
Crap. Daniel...we could really use the ability to do this legitimately... Might have to revert this for now...sigh. The fix wasn't nearly as bad as I feared: http://lists.freedesktop.org/archives/mesa-dev/2013-May/039713.html We can just go back to using the kernel SOL reset feature, but in a simpler fashion than before. MI_STORE_REGISTER_MEM seems to work, so we don't need to revert everything. On my Haswell system, that fixes every regression caused by the bisected commit. Also, thanks for the report! Sorry for not catching this earlier. Fixed by: commit 90b46f2d5ac336f63fff9b4681216a99e4163893 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Thu May 23 20:19:19 2013 -0700 i965: Go back to using the kernel SOL reset feature. It turns out the MI_LOAD_REGISTER_IMM approach doesn't work on Haswell, and regressed essentially all the transform feedback Piglit tests. This morally reverts eaa6fbe6d54dc99efac4ab8e800edef65ce8220d. However, the code is still simpler than it was. On BeginTransformFeedback, we simply flush the batch and set the SOL reset flag so that the next batch will start with zeroed offsets. There's still no software counting. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64887 Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Paul Berry <stereotype441@gmail.com> Reviewed-by: Eric Anholt <eric@anholt.net> This regression only existed on master, so there's nothing to backport. My apologies...that should have been: commit 062317d6671ed42ed10b24ee9d3df87c1dab279d Author: Kenneth Graunke <kenneth@whitecape.org> Date: Thu May 23 20:19:19 2013 -0700 i965: Go back to using the kernel SOL reset feature. Verified.Fixed. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.