Bug 65161

Summary:	Systemd code path in act-user-manager is quite obfuscated.
Product:	accountsservice	Reporter:	Marius Vollmer <marius.vollmer>
Component:	general	Assignee:	Matthias Clasen <mclasen>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium	CC:	rstrode
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Marius Vollmer 2013-05-30 07:40:17 UTC

The systemd specific code path in act-user-manager is threaded into the middle of the state machines of load_seat_incrementally and load_new_session_incrementally.

I think it would be much cleaner to just branch once for systemd in load_idle or similar and just use its synchronous API in a straight line.  If you feel the same, I'd be happy to make a patch.

Comment 1 Ray Strode [halfline] 2013-10-15 20:17:51 UTC

i do feel the same. Please make the patch!

Comment 2 Marius Vollmer 2013-10-16 06:21:18 UTC

(In reply to comment #1)
> i do feel the same. Please make the patch!

Alright!

Comment 3 GitLab Migration User 2018-08-07 09:32:14 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/accountsservice/accountsservice/issues/28.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.