Bug 65193

Summary:	[bisected] r600g, can't launch Gnome Shell and KDE since mesa updated to 5de41575a127eb8a6a0fe5c71a73b372f9b89f53
Product:	Mesa	Reporter:	Alexandre Demers <alexandre.f.demers>
Component:	Drivers/Gallium/r600	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	medium	CC:	ptpzz
Version:	git
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	[PATCH] r600g/sb: fix broken assert

Description Alexandre Demers 2013-05-30 23:02:29 UTC

I haven't been able to log in Gnome Shell or KDE lately since I updated mesa from git. Using XFCE and doing some tests, I've found out glxgears returns an assertion error when launch. glxgears fails with the following error:
sb/sb_expr.cpp:455:fold_alu_op2: Assertion `v0 && v1 && n.dst[0]' failed.
line 6: 15521 Trace/breakpoint trap   (core dumped) $1

Bisecting ended up point to culprit commit:
commit 5de41575a127eb8a6a0fe5c71a73b372f9b89f53
Author: Vadim Girlin <vadimgirlin@gmail.com>
Date:   Mon May 27 14:23:47 2013 +0400

    r600g/sb: improve folding for SETcc
    
    Signed-off-by: Vadim Girlin <vadimgirlin@gmail.com>

:040000 040000 96a6fd8851d84f62896ecfba6c4a7df5a7963325 ade9a1e6d7fd56ed8cf413a2138c38011f1b9827 M	src


Using latest drm, ddx from git on a Radeon HD6950 Cayman.

Comment 1 Alexandre Demers 2013-05-30 23:35:34 UTC

It seems the identified failed assertion is not the prime root of Gnome Shell and KDE not launching. A previous commit must be the culprit for the other problem (I'm tracking it down right now). However, commit 5de41575a127eb8a6a0fe5c71a73b372f9b89f53 does prevent glxgears from running as it should.

Comment 2 Alexandre Demers 2013-05-30 23:42:29 UTC

(In reply to comment #1)
> It seems the identified failed assertion is not the prime root of Gnome
> Shell and KDE not launching. A previous commit must be the culprit for the
> other problem (I'm tracking it down right now). However, commit
> 5de41575a127eb8a6a0fe5c71a73b372f9b89f53 does prevent glxgears from running
> as it should.

Forget about what I just said, I made a mistake, wrongly resync before last build. Retesting right away.

Comment 3 Alexandre Demers 2013-05-30 23:58:39 UTC

commit 5de41575a127eb8a6a0fe5c71a73b372f9b89f53 is really the first bad commit preventing Gnome Shell and KDE from starting correctly (Gnome ends with a Oops and KDE just fails and relaunches X).

Comment 4 Andreas Boll 2013-05-31 12:44:10 UTC

Are you using the default backend + sb or llvm backend + sb?

Ccing vadimg.

Comment 5 Vadim Girlin 2013-05-31 13:42:17 UTC

Created attachment 80097 [details] [review]
[PATCH] r600g/sb: fix broken assert

Attached patch should fix the assert. Does it fix you issues?

Comment 6 Alexandre Demers 2013-05-31 17:00:01 UTC

(In reply to comment #4)
> Are you using the default backend + sb or llvm backend + sb?
> 
> Ccing vadimg.

R600_DEBUG=sb is set.

In my build script, I set the following:
baseExec="./autogen.sh --prefix=/usr \
		--enable-debug \
		--enable-osmesa \
		--enable-gbm \
		--enable-xvmc \
		--enable-vdpau \
		--enable-gles1 \
		--enable-gles2 \
		--enable-openvg \
		--enable-xorg \
		--enable-xa \
		--enable-egl \
		--enable-gallium-egl \
		--enable-glx-tls \
		--enable-texture-float \
		--enable-wgl \
		--with-gallium-drivers=r600,swrast,svga \
		--with-dri-drivers= \
		--with-egl-platforms=x11,drm,wayland"

So that would be default + SB, right?

Comment 7 Alexandre Demers 2013-05-31 17:14:12 UTC

(In reply to comment #5)
> Created attachment 80097 [details] [review] [review]
> [PATCH] r600g/sb: fix broken assert
> 
> Attached patch should fix the assert. Does it fix you issues?

Yes, it does.

Comment 8 Vadim Girlin 2013-05-31 18:19:17 UTC

Patch pushed with commit eb4c992ea5e69083d2bc705d2460ce956c5063a7

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.