Bug 65207

Summary: Journald does not take KeepFree into account when reporting maximum journal size
Product: systemd Reporter: Daniel Albers <daniel>
Component: generalAssignee: systemd-bugs
Status: RESOLVED FIXED QA Contact: systemd-bugs
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch: journal: take KeepFree into account when reporting maximum size
Patch: print hint about KeepFree when it actually limits journal size

Description Daniel Albers 2013-05-31 12:12:09 UTC
Created attachment 80087 [details]
Patch: journal: take KeepFree into account when reporting maximum size

During startup journald reports "Allowing (runtime|system) journal files to grow to %s.", but only takes the *MaxUse metric into account. It is unclear to the user, that the *KeepFree setting might limit available space to a lower value.

Attached patch replaces the KeepFree metric in that message with a call to available_space().
Comment 1 Daniel Albers 2013-05-31 12:57:20 UTC
Created attachment 80092 [details] [review]
Patch: print hint about KeepFree when it actually limits journal size

Modified the patch to check if KeepFree actually imposes a limit on journal size and only then report on it and actually mention the setting.

Peter Sztan adds for consideration: "The other question that comes to mind is whether to print this when rotating the journal and what severity it should be."
Comment 2 Zbigniew Jedrzejewski-Szmek 2013-06-01 13:17:40 UTC
Applied in http://cgit.freedesktop.org/systemd/systemd/commit/?id=fe1abefcd3. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.