| Summary: | [softpipe] piglit interpolation-none-gl_BackColor-flat-fixed regression | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Vinson Lee <vlee> |
| Component: | Mesa core | Assignee: | mesa-dev |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | zackr |
| Version: | git | Keywords: | regression |
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
That seems to be passing now, is that right? I think I fixed it in a commit 978d5ed06bfc3d87a4b1ca1981caeeaa88de2790 "draw: fix vs/fs input/output mismatches" committed right after the one you mentioned. (In reply to comment #1) > That seems to be passing now, is that right? I think I fixed it in a commit > 978d5ed06bfc3d87a4b1ca1981caeeaa88de2790 "draw: fix vs/fs input/output > mismatches" committed right after the one you mentioned. mesa: c754f7a8fd53906acb9ef6ade715481a2c9f17de (master) Test still fails. Thanks Vinson. It should be now fixed with e54c924a0e9b9a504eae1eb68daaf51f21689629 , "softpipe: draw_find_shader_output returns -1 on invalid outputs". mesa: f3bbf65929e395360e5565d08d015977dd5b79fa (master) piglit interpolation-none-gl_BackColor-flat-fixed now passes on softpipe with latest master. commit e54c924a0e9b9a504eae1eb68daaf51f21689629 Author: Zack Rusin <zackr@vmware.com> Date: Thu May 30 17:01:19 2013 -0400 softpipe: draw_find_shader_output returns -1 on invalid outputs It was changed from 0 to allow shader outputs at 0 that are different from position. Signed-off-by: Zack Rusin <zackr@vmware.com> Reviewed-by: Brian Paul <brianp@vmware.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
mesa: 869c5d438f137b2c6b9aec1dddc00bfa64f36621 (master) $ ./bin/shader_runner generated_tests/spec/glsl-1.10/execution/interpolation/interpolation-none-gl_BackColor-flat-fixed.shader_test -auto Mesa warning: failed to remap glClampColorARB Mesa warning: failed to remap glTexBufferARB Mesa warning: failed to remap glFramebufferTextureARB Mesa warning: failed to remap glVertexAttribDivisorARB Mesa warning: failed to remap glProgramParameteriARB Probe at (159,45) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (192,38) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (216,33) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (166,83) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (196,71) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (136,136) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (173,115) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 Probe at (145,166) Expected: 0.000000 0.000000 1.000000 1.000000 Observed: 1.000000 1.000000 0.000000 0.572549 PIGLIT: {'result': 'fail' } 4b5595b38b3884531624fab6def7c604e92d0914 is the first bad commit commit 4b5595b38b3884531624fab6def7c604e92d0914 Author: Zack Rusin <zackr@vmware.com> Date: Fri May 24 16:39:59 2013 -0400 draw: fixup draw_find_shader_output draw_find_shader_output like most of the code in draw used to depend on position always being at output slot 0. which meant that any other attribute being at 0 could signify an error. unfortunately position can be at any of the output slots, thus other attributes can occupy slot 0 and we need to mark the ones which were not found by something else. This commit changes draw_find_shader_output so that it returns -1 if it can't find the given attribute and adjust the code that depended on it returning >0 whenever it correctly found an attrib. Signed-off-by: Zack Rusin <zackr@vmware.com> Reviewed-by: José Fonseca<jfonseca@vmware.com> Reviewed-by: Brian Paul <brianp@vmware.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> :040000 040000 677fc576c96383eabe6210f6a82e19592b7b59cf 220034f286f44d7e00165cfba49f5204ee1b1589 M src bisect run success