Bug 65423

Summary: Remove gl_config::haveDepthBuffer, haveAccumBuffer, haveStencilBuffer fields
Product: Mesa Reporter: Brian Paul <brianp>
Component: Mesa coreAssignee: mesa-dev
Status: RESOLVED MOVED QA Contact:
Severity: trivial    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Brian Paul 2013-06-05 15:31:27 UTC
Another simple clean-up task:

These boolean fields are redundant.  Instead of code checking "if (visual->haveDepthBuffer)" we can simply do "if (visual->depthBits > 0)".
Comment 1 Arnas Milaševičius 2013-06-07 21:00:19 UTC
struct gl_config doesn't have member accumBits, but it has accumR, accumG and accumB members. Maybe I should change `if(visual->haveAccumBuffer)` to if((visual->accumG + visual->accumB + visual-> accumR) > 0)`?
Comment 2 Brian Paul 2013-06-07 22:53:22 UTC
(In reply to comment #1)
> struct gl_config doesn't have member accumBits, but it has accumR, accumG
> and accumB members. Maybe I should change `if(visual->haveAccumBuffer)` to
> if((visual->accumG + visual->accumB + visual-> accumR) > 0)`?

Sounds good.
Comment 3 GitLab Migration User 2019-09-18 20:23:12 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/976.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.