Bug 6545

Summary:	depend with xorg/proto/XF86DRI/dri_interface.h breaks the building process
Product:	Mesa	Reporter:	Shang-Feng Yang <sfyang>
Component:	Drivers/DRI/i810	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	high
Version:	git
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	The dirty workaround for the dependency problem

Description Shang-Feng Yang 2006-04-10 04:09:11 UTC

The "Mesa/include/GL/internal/dri_interface.h" in the current CVS head is
different from that of "xorg/proto/XF86DRI/dri_interface.h" of the current CVS
head which is imported from Mesa 6.4.1. There are some additional member
function in the struct __DRIdrawableRec like copySubBuffer which is undefined in
the xorg/proto/XF86DRI/dri_interface.h. 

The problem is, when building the dri drivers in the "Mesa/src/drivers/dri/*",
since the rule in the "Mesa/src/drivers/dri/Makefile.template" for generating
"depend" file calls pkg-config to find the CFLAGS of libdrm that will returns
the path pointed to the installed xorg/proto/XF86DRI/dri_interface.h, and this
occurs earilier to the path pointed to the
Mesa/include/GL/internal/dri_interface.h, the building process will break when
compiling Mesa/src/mesa/drivers/dri/common/dri_utils.h which includes the
dri_interface.h for the definition of struct __DRIdrawableRec for undefined
member "copySubBuffer".

I made a dirty patch that just change some parameters' order of the
SHARED_INCLUDE variable in the Makefile.template to workaround this problem.
However, the more correct way should be re-importing the new dri_interface.h
into the xorg/proto/XF86DRI  CVS tree.

Comment 1 Shang-Feng Yang 2006-04-10 04:13:26 UTC

Created attachment 5241 [details] [review]
The dirty workaround for the dependency problem

Here is the patch I mentioned in my bug report. It just move the order of
calling 'pkg-config --cflags libdrm' to somewhere after '-I$(TOP)/include' to
force the makedepend using the Mesa/include/GL/internal/dri_interface.h as its
first choice.

Comment 2 Shawn Starr 2006-04-21 14:20:43 UTC

The hack worked as of April 20th, 2006 I am able to build Mesa HEAD fine.

Comment 3 Dave Airlie 2006-05-16 18:53:01 UTC

This should be fixed in Mesa CVS.

Comment 4 Adam Jackson 2009-08-24 12:23:47 UTC

Mass version move, cvs -> git

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.